switch interpolation placeholder to comment#104
Merged
Conversation
|
Size Change: -19.1 kB (-86.32%) 🏆 Total Size: 3.03 kB
ℹ️ View Unchanged
|
|
Bencher Report| Branch | push-znmornkoznrm |
| Testbed | gha |
🚨 1 Alert
| Benchmark | Measure Units | View | Benchmark Result (Result Δ%) | Lower Boundary (Limit %) |
|---|---|---|---|---|
| table/large/activate | heap megabytes (MB) | 📈 plot 🚷 threshold 🚨 alert (🔔) | 5.57 MB(-30.14%)Baseline: 7.98 MB | 6.23 MB (111.78%) |
Click to view all benchmark results
| Benchmark | duration | Benchmark Result microseconds (µs) (Result Δ%) | Lower Boundary microseconds (µs) (Limit %) | heap | Benchmark Result kilobytes (KB) (Result Δ%) | Lower Boundary kilobytes (KB) (Limit %) |
|---|---|---|---|---|---|---|
| anim/large/advance | 📈 view plot 🚷 view threshold | 9,985.65 µs(-21.72%)Baseline: 12,755.98 µs | 8,200.17 µs (82.12%) | 📈 view plot 🚷 view threshold | 3,426.37 KB(+8.84%)Baseline: 3,148.15 KB | 2,428.77 KB (70.88%) |
| anim/small/advance | 📈 view plot 🚷 view threshold | 4,216.77 µs(-16.09%)Baseline: 5,025.61 µs | 3,696.76 µs (87.67%) | 📈 view plot 🚷 view threshold | 1,073.67 KB(+6.64%)Baseline: 1,006.82 KB | 742.81 KB (69.18%) |
| table/large/activate | 📈 view plot 🚷 view threshold | 29,259.62 µs(+7.65%)Baseline: 27,180.63 µs | 24,376.01 µs (83.31%) | 📈 view plot 🚷 view threshold 🚨 view alert (🔔) | 5,574.12 KB(-30.14%)Baseline: 7,979.04 KB | 6,230.57 KB (111.78%) |
| table/large/filter | 📈 view plot 🚷 view threshold | 91,980.05 µs(+87.08%)Baseline: 49,167.02 µs | 28,846.77 µs (31.36%) | 📈 view plot 🚷 view threshold | 15,513.79 KB(+88.29%)Baseline: 8,239.24 KB | 4,902.97 KB (31.60%) |
| table/large/removeAll | 📈 view plot 🚷 view threshold | 69,373.99 µs(+90.66%)Baseline: 36,387.04 µs | 22,832.69 µs (32.91%) | 📈 view plot 🚷 view threshold | 13,468.06 KB(+100.25%)Baseline: 6,725.73 KB | 3,533.77 KB (26.24%) |
| table/large/render | 📈 view plot 🚷 view threshold | 32,543.11 µs(+25.70%)Baseline: 25,889.77 µs | 22,474.99 µs (69.06%) | 📈 view plot 🚷 view threshold | 10,573.62 KB(+25.66%)Baseline: 8,414.65 KB | 6,575.64 KB (62.19%) |
| table/large/sort | 📈 view plot 🚷 view threshold | 84,977.20 µs(+83.64%)Baseline: 46,274.46 µs | 27,959.86 µs (32.90%) | 📈 view plot 🚷 view threshold | 9,542.04 KB(+54.12%)Baseline: 6,191.38 KB | 3,784.53 KB (39.66%) |
| table/small/activate | 📈 view plot 🚷 view threshold | 2,731.44 µs(+5.58%)Baseline: 2,587.12 µs | 2,145.12 µs (78.53%) | 📈 view plot 🚷 view threshold | 1,251.34 KB(+49.02%)Baseline: 839.70 KB | 446.60 KB (35.69%) |
| table/small/filter | 📈 view plot 🚷 view threshold | 5,344.45 µs(+41.70%)Baseline: 3,771.74 µs | 2,581.11 µs (48.30%) | 📈 view plot 🚷 view threshold | 1,791.16 KB(+97.33%)Baseline: 907.70 KB | 537.31 KB (30.00%) |
| table/small/removeAll | 📈 view plot 🚷 view threshold | 4,571.80 µs(+50.71%)Baseline: 3,033.51 µs | 2,111.48 µs (46.18%) | 📈 view plot 🚷 view threshold | 649.58 KB(+73.45%)Baseline: 374.51 KB | 87.24 KB (13.43%) |
| table/small/render | 📈 view plot 🚷 view threshold | 3,797.03 µs(+20.70%)Baseline: 3,145.82 µs | 2,365.55 µs (62.30%) | 📈 view plot 🚷 view threshold | 1,296.88 KB(+80.22%)Baseline: 719.63 KB | 498.73 KB (38.46%) |
| table/small/sort | 📈 view plot 🚷 view threshold | 6,003.73 µs(+57.76%)Baseline: 3,805.54 µs | 2,388.51 µs (39.78%) | 📈 view plot 🚷 view threshold | 1,010.51 KB(+61.11%)Baseline: 627.22 KB | 376.57 KB (37.27%) |
| tree/large/removeAll | 📈 view plot 🚷 view threshold | 2,972.39 µs(-20.89%)Baseline: 3,757.17 µs | 2,705.36 µs (91.02%) | 📈 view plot 🚷 view threshold | 1,075.63 KB(+6.03%)Baseline: 1,014.47 KB | 825.90 KB (76.78%) |
| tree/large/render | 📈 view plot 🚷 view threshold | 2,963.04 µs(-9.40%)Baseline: 3,270.35 µs | 2,713.71 µs (91.59%) | 📈 view plot 🚷 view threshold | 1,158.30 KB(+10.29%)Baseline: 1,050.25 KB | 823.44 KB (71.09%) |
| tree/large/reverse | 📈 view plot 🚷 view threshold | 3,834.29 µs(-12.61%)Baseline: 4,387.50 µs | 3,338.00 µs (87.06%) | 📈 view plot 🚷 view threshold | 1,103.08 KB(+31.44%)Baseline: 839.26 KB | 591.60 KB (53.63%) |
| tree/small/insertFirst | 📈 view plot 🚷 view threshold | 587.21 µs(-7.10%)Baseline: 632.07 µs | 480.83 µs (81.88%) | 📈 view plot 🚷 view threshold | 204.52 KB(+15.01%)Baseline: 177.82 KB | 139.27 KB (68.10%) |
| tree/small/insertLast | 📈 view plot 🚷 view threshold | 540.57 µs(-9.53%)Baseline: 597.52 µs | 456.80 µs (84.50%) | 📈 view plot 🚷 view threshold | 202.69 KB(+20.54%)Baseline: 168.15 KB | 131.13 KB (64.70%) |
| tree/small/moveFromEndToStart | 📈 view plot 🚷 view threshold | 529.25 µs(-5.55%)Baseline: 560.34 µs | 409.03 µs (77.28%) | 📈 view plot 🚷 view threshold | 127.15 KB(+14.11%)Baseline: 111.43 KB | 85.86 KB (67.52%) |
| tree/small/moveFromStartToEnd | 📈 view plot 🚷 view threshold | 535.52 µs(-9.10%)Baseline: 589.11 µs | 441.27 µs (82.40%) | 📈 view plot 🚷 view threshold | 157.73 KB(+15.81%)Baseline: 136.20 KB | 108.55 KB (68.82%) |
| tree/small/no_change | 📈 view plot 🚷 view threshold | 396.59 µs(-10.63%)Baseline: 443.75 µs | 382.03 µs (96.33%) | 📈 view plot 🚷 view threshold | 152.66 KB(+11.99%)Baseline: 136.31 KB | 109.57 KB (71.78%) |
| tree/small/removeAll | 📈 view plot 🚷 view threshold | 388.93 µs(-31.54%)Baseline: 568.14 µs | 369.16 µs (94.92%) | 📈 view plot 🚷 view threshold | 129.77 KB(-14.11%)Baseline: 151.09 KB | 123.47 KB (95.15%) |
| tree/small/removeFirst | 📈 view plot 🚷 view threshold | 576.13 µs(-6.37%)Baseline: 615.35 µs | 470.10 µs (81.60%) | 📈 view plot 🚷 view threshold | 162.10 KB(+19.77%)Baseline: 135.34 KB | 108.93 KB (67.20%) |
| tree/small/removeLast | 📈 view plot 🚷 view threshold | 454.91 µs(-7.53%)Baseline: 491.96 µs | 401.50 µs (88.26%) | 📈 view plot 🚷 view threshold | 150.17 KB(+20.05%)Baseline: 125.09 KB | 100.67 KB (67.04%) |
| tree/small/render | 📈 view plot 🚷 view threshold | 543.09 µs(-2.19%)Baseline: 555.25 µs | 477.14 µs (87.86%) | 📈 view plot 🚷 view threshold | 167.58 KB(+3.73%)Baseline: 161.56 KB | 141.37 KB (84.36%) |
| tree/small/reverse | 📈 view plot 🚷 view threshold | 551.88 µs(-9.09%)Baseline: 607.06 µs | 452.96 µs (82.08%) | 📈 view plot 🚷 view threshold | 123.03 KB(+3.64%)Baseline: 118.71 KB | 80.30 KB (65.27%) |
| tree/worst_case/kivi | 📈 view plot 🚷 view threshold | 1,184.00 µs(+11.32%)Baseline: 1,063.60 µs | 691.07 µs (58.37%) | 📈 view plot 🚷 view threshold | 299.97 KB(+26.30%)Baseline: 237.50 KB | 170.75 KB (56.92%) |
| tree/worst_case/react | 📈 view plot 🚷 view threshold | 1,244.41 µs(+22.10%)Baseline: 1,019.20 µs | 472.17 µs (37.94%) | 📈 view plot 🚷 view threshold | 308.42 KB(+22.19%)Baseline: 252.40 KB | 177.66 KB (57.60%) |
| tree/worst_case/snabbdom | 📈 view plot 🚷 view threshold | 968.59 µs(-10.91%)Baseline: 1,087.27 µs | 810.10 µs (83.64%) | 📈 view plot 🚷 view threshold | 280.48 KB(+23.72%)Baseline: 226.70 KB | 168.93 KB (60.23%) |
| tree/worst_case/virtual_dom | 📈 view plot 🚷 view threshold | 941.31 µs(-11.56%)Baseline: 1,064.34 µs | 807.34 µs (85.77%) | 📈 view plot 🚷 view threshold | 280.41 KB(+25.03%)Baseline: 224.28 KB | 150.93 KB (53.82%) |
tombl
force-pushed
the
push-znmornkoznrm
branch
6 times, most recently
from
58135e1 to
6565f6b
Compare
tombl
force-pushed
the
push-znmornkoznrm
branch
2 times, most recently
from
bdb9d87 to
5df5c8b
Compare
use a comment in child position, or text in attribute position
also fix span iteration implementation because we don't actually want the existence of a next sibling to be an execution condition
replace it with root.render(null)
tombl
force-pushed
the
push-znmornkoznrm
branch
2 times, most recently
from
74261ec to
ffff28f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #100