feat: support fork PRs in rebase-pr action (#11)#17
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the rebase-pr action by adding support for pull requests submitted from forks. By dynamically detecting the source repository and configuring temporary remotes, the action now correctly handles rebasing and pushing changes for cross-repository contributions, ensuring a seamless workflow for open-source maintainers. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a shell script for automated PR rebasing that leverages the GitHub CLI and temporary git worktrees, including support for fork repositories. The review feedback highlights a critical bug where the script could crash on non-fork PRs due to null JSON property access and suggests refactoring duplicated logic for cleanup traps and output generation into reusable functions to improve maintainability and follow DRY principles.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
/rebase |
What
Updated
rebase-pr/run.shto detect cross-repository (fork) PRs and dynamically configure a separate Git remote for the head repository, enabling fetch and push to/from the fork instead of always assumingorigin.Why
Closes #11. Previously the script assumed both branches were on
origin, causing it to fail for PRs submitted from forks — a common open-source workflow.Originally flagged by @gemini-code-assist in #10.
How
Uses
gh pr view --json isCrossRepository,headRepositoryto detect fork PRs. If cross-repo:fork-remotepointing to the fork's clone URLfork-remoteinstead oforiginfork-remotetrapon exitSame-repo PRs continue using
originwith no behavioural change.Checklist
rebase-pr/README.md— mention fork PR support)