fix: support autoGetResponse option in card.transmit()#106
Merged
Conversation
Add CardWrapper class that wraps native Card objects to intercept transmit() calls and automatically handle T=0 protocol status words (SW1=61, SW1=6C) when autoGetResponse option is set. The Devices class now wraps all cards with CardWrapper, making the autoGetResponse option work directly with card.transmit() instead of requiring users to call transmitWithAutoResponse() separately. Fixes #105
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
autoGetResponseoption inTransmitOptionsnow works when passed directly tocard.transmit():Previously, users had to use the separate
transmitWithAutoResponse()function.Changes
CardWrapperclass that wraps native cards to intercepttransmit()callsDevicesclass now wraps all connected cards withCardWrapperCardWrapperandwrapCardfor low-level API users who want this functionalityTransmitOptions.autoGetResponsedocumentationHow it works
When
autoGetResponse: trueis passed totransmit(), the wrapper delegates totransmitWithAutoResponse()which handles:SW1=61: Sends GET RESPONSE to retrieve remaining dataSW1=6C: Retries with corrected Le valueFixes #105
Test plan
card.transmit()withautoGetResponse: true