Merged
Conversation
yehonatanz
requested changes
Mar 31, 2020
marine/marine.py
Outdated
|
|
||
| def validate_bpf(self, bpf: str) -> bool: | ||
| bpf = bpf.encode("utf-8") | ||
| if self._marine.validate_bpf(bpf) < 0: |
Collaborator
There was a problem hiding this comment.
< or !=? What's more likely to remain correct?
(Not rehtorical, actually asking)
Owner
There was a problem hiding this comment.
Why doesn't it return a boolean? I see no applications for error codes here.
marine/marine.py
Outdated
|
|
||
| def validate_bpf(self, bpf: str) -> bool: | ||
| bpf = bpf.encode("utf-8") | ||
| if self._marine.validate_bpf(bpf) < 0: |
Collaborator
There was a problem hiding this comment.
Instead of:
if cond:
return False
return Trueuse:
return not cond
tomlegkov
requested changes
Mar 31, 2020
marine/marine.py
Outdated
|
|
||
| def validate_bpf(self, bpf: str) -> bool: | ||
| bpf = bpf.encode("utf-8") | ||
| if self._marine.validate_bpf(bpf) < 0: |
Owner
There was a problem hiding this comment.
Why doesn't it return a boolean? I see no applications for error codes here.
yehonatanz
approved these changes
Mar 31, 2020
tomlegkov
approved these changes
Mar 31, 2020
Owner
tomlegkov
left a comment
tomlegkov
left a comment
There was a problem hiding this comment.
Don't merge until the C part is done :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.