Added support for choosing encapsulation type#27
Merged
shaharyarn merged 15 commits intomasterfrom May 31, 2020
Merged
Conversation
yehonatanz
reviewed
May 10, 2020
Collaborator
yehonatanz
left a comment
yehonatanz
left a comment
There was a problem hiding this comment.
Looks good, not approving yet due to potential marine-core changes
…/marine-python into feature/choosing-encapsulation
tomlegkov
requested changes
May 13, 2020
Owner
tomlegkov
left a comment
tomlegkov
left a comment
There was a problem hiding this comment.
Except for the tests, I think the benchmark should be changed like how I suggested in the core PR. But that's definitely not required and up to @yehonatanz :)
| @@ -5,44 +5,53 @@ | |||
| from typing import List, Union, Optional, Dict | |||
Owner
There was a problem hiding this comment.
I think some more tests are required:
- Test that different encapsulations affect BPF validation
- Test that different encapsulations affect parsing
- Show that display filter validation works for types of different encapsulation (for example, add a test that shows both
radiotapandethernetare valid display filters without needing to specify encapsulation)
Collaborator
Author
There was a problem hiding this comment.
I added a test that checks for effect on BPF validation and tests that affect parsing.
I could not add a test that checks the 3rd requirement as the display filter validation is not affected by encapsulation type, as the display filter is not dependent on it during compilation.
yehonatanz
approved these changes
May 24, 2020
|
|
||
| ENCAP_ETHERNET = 1 | ||
|
|
||
| """Your friendly neighbourhood wifi""" |
tomlegkov
approved these changes
May 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.