Do not call destructor if Marine was not initialized properly#37
Merged
yehonatanz merged 3 commits intomasterfrom Jul 13, 2020
Merged
Do not call destructor if Marine was not initialized properly#37yehonatanz merged 3 commits intomasterfrom
yehonatanz merged 3 commits intomasterfrom
Conversation
yehonatanz
requested changes
Jul 13, 2020
Collaborator
yehonatanz
left a comment
yehonatanz
left a comment
There was a problem hiding this comment.
Have you ran black on the code?
marine/marine.py
Outdated
|
|
||
| def __del__(self): | ||
| self._marine.destroy_marine() | ||
| if hasattr(self, '_marine') and self._marine: |
Collaborator
There was a problem hiding this comment.
Can be simply:
if getattr(self, "_marine"):
...
Collaborator
There was a problem hiding this comment.
Oops I meant:
if getattr(self, "_marine", None):
...
yehonatanz
approved these changes
Jul 13, 2020
tomlegkov
approved these changes
Jul 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes issue #18