Merged
Conversation
tomlegkov
requested changes
Sep 21, 2020
| def validate_fields( | ||
| fields: List[str], | ||
| macros: Optional[Dict[str, List[str]]] = None, | ||
| fields: List[str], field_templates: Optional[Dict[str, List[str]]] = None |
| def _expand_macros( | ||
| self, fields: List[str], macros: Optional[Dict[str, List[str]]] | ||
| def _expand_field_templates( | ||
| self, fields: List[str], field_templates: Optional[Dict[str, List[str]]] |
Owner
There was a problem hiding this comment.
Maybe also need to run Black here? Or does it place multiple parameters in the same line?
Collaborator
Author
There was a problem hiding this comment.
It is blacked. It does place the parameters in the same line.
Same goes for the other formatting comment.
yehonatanz
approved these changes
Sep 21, 2020
Collaborator
yehonatanz
left a comment
yehonatanz
left a comment
There was a problem hiding this comment.
Approved up to @tomlegkov's comments
tomlegkov
approved these changes
Sep 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.