Merged
Conversation
yehonatanz
approved these changes
Dec 8, 2020
domerd
force-pushed
the
change/better-parsing
branch
from
a067b75 to
c4cca09
Compare
yehonatanz
previously requested changes
Jan 10, 2021
marine/marine.py
Outdated
| csv_parsed_output = next(csv.reader(f, delimiter="\t", quotechar='"'), [""]) | ||
| return [value or None for value in csv_parsed_output] | ||
| return ( | ||
| output[i].decode("utf-8") if output[i] is not None else None |
Collaborator
There was a problem hiding this comment.
Also str has no decode in python3, so that should probably be bytes anyway
tomlegkov
approved these changes
Jan 10, 2021
marine/marine.py
Outdated
| @staticmethod | ||
| def _parse_output(output: str) -> List[Optional[str]]: | ||
| def _parse_output(output: List[str], length: int) -> List[Optional[str]]: | ||
| # TODO: this is a bottleneck. Find a better way to provide output from the c code |
Owner
There was a problem hiding this comment.
Is this still a bottleneck? How much faster is this code now?
Collaborator
There was a problem hiding this comment.
On average the code is 5% faster.
In some cases (in tests without fields) we slowed the test a bit - might be some overhead we are paying for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.