walkthrough: wire highlightLines into StopArtifact diff & whole-file views#8
Merged
tomplex merged 2 commits intoMay 18, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wires
highlightLines()(added in fed2816) into the walkthrough'sStopArtifactviews. The diff view and whole-file view already use it; the walkthrough's artifact diff and expanded whole-file view were missed in that commit, so multi-line tokens (docstrings, template literals, block comments) still render incorrectly inside walkthrough stops.The wiring mirrors
DiffView.precomputeHighlightsexactly: each hunk is split into old-side (context + del) and new-side (context + add) blocks, each block is highlighted as one unit, and the resulting per-line HTML is passed toDiffLinevia the existinghighlightedHtmlprop. The expanded whole-file view passes its full content as one block.Repro
Open a walkthrough on any Python file with a multi-line `"""docstring"""`. Before this PR, words like
dict,list,frominside the docstring body get keyword/type colors. After, the whole docstring body renders as a single string color.Test plan
🤖 Generated with Claude Code