Implement Powermeter TQ EM#150
Merged
Merged
Conversation
This was referenced Jun 26, 2025
Closed
Closed
Closed
Closed
|
Code is much nicer but returns wrong value(s) ;-) The power is always reported in two different values (e.g. one for the power coming from the grid and one for the power that is fed to the grid). To get a signed total you need to calculate the value by subtracting the power that is fed to the grid from the power that is drawn from the grid. At least one of those values will always be zero. Note sure why you extract the phase power as well, but you would need to calculate the total phase power accordingly. "tq_tm.py" needs to be changed as follows: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
pytest -qFixes #133