Skip to content
This repository was archived by the owner on Dec 15, 2023. It is now read-only.

Conversation

@tomrtk
Copy link
Owner

@tomrtk tomrtk commented Dec 20, 2022

remove LFS and download weights from release instead

resolve #442

@tomrtk tomrtk force-pushed the refactor/workflow branch 3 times, most recently from 3a40870 to 92c2e6e Compare December 20, 2022 12:01
@tomrtk tomrtk changed the title refactor: remove LFS for ci refactor: remove LFS from ci Dec 20, 2022
@tomrtk tomrtk requested a review from MindTooth December 20, 2022 12:05
@tomrtk tomrtk added enhancement New feature or request ci done github_actions Pull requests that update Github_actions code labels Dec 20, 2022
@tomrtk tomrtk force-pushed the refactor/workflow branch 2 times, most recently from 7fc8115 to 9abb4a4 Compare December 20, 2022 12:11
remove LFS and download weights from release instead
@MindTooth MindTooth merged commit 5895bb8 into master Dec 20, 2022
@MindTooth MindTooth deleted the refactor/workflow branch December 20, 2022 14:29
@MindTooth
Copy link
Collaborator

@tomrtk: To be clear, this means that we do not use LFS and .gitattributes can removed?

@tomrtk
Copy link
Owner Author

tomrtk commented Aug 4, 2023

@tomrtk: To be clear, this means that we do not use LFS and .gitattributes can removed?

No, still using LFS for clone repo. This was just for ci.

If removing lfs we should probably make it easy/automatic to get weights downloaded as part of development environment setup.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ci done enhancement New feature or request github_actions Pull requests that update Github_actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hack: use v1.0.0 release to download model

3 participants