Add rename text input handler

[predragnikolic]

Ask for new symbol name though the command palette, instead of the window input panel. #206

There is a comment I left for you to have a look.

Can you please tell me, what the purpose of the event argument in the run method and when do you pass it by to the command?

class LspSymbolRenameCommand(LspTextCommand):
    #...
    def run(self, edit, new_name, event=None):
        pos = get_position(self.view, event)
        params = get_document_position(self.view, pos)

Also Tom, is there something you would like to change? :)

[coveralls]

Pull Request Test Coverage Report for Build 795

• 0 of 24 (0.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.3%) to 17.158%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
plugin/rename.py	0	24	0.0%

Totals
Change from base Build 789:	0.3%
Covered Lines:	466
Relevant Lines:	2716

---

💛 - Coveralls

[tomv564]

Awesome work, great demo also!
I guess users need a recent-ish Sublime Text build (7 May 2018) - if it turns out this build is not available to a lot of our users then we could do a feature detection.

[tomv564]

The event parameter is provided when the command is triggered by mouse click, for example when right-clicking on a symbol.

Did you test the rename from the context menu after your changes?

Also, I like to make it clear to the user when commands are not supported by LSP.
You added Rename to the panel so it will appear to work even when the server does not support it?

[rwols]

You could also choose to change the minimum required build number in your package control submission.

[predragnikolic]

Thanks for explaining :)

Did you test the rename from the context menu after your changes?

Sorry, I didn't, but I fixed it.
And now renaming works in all three cases, when it is triggered through the:

• keyboard shortcut
• context menu
• command palette

You added Rename to the panel so it will appear to work even when the server does not support it?

The command must be present in the command palette for this to work (see second paragraph), but Sublime won't show the command in the command palette if the is_enabled returns False, so the command will only be visible if the user can actually rename the symbol.

we could do a feature detection?

I will let you decide if you want a feature detection :)

Note: In the python language server, if I rename a symbol, and try to rename it again, it wont take affect. But if I rename the symbol, save the file, and then rename it again, it works.
In your typescript language server, everything works great, I can rename the symbol as much as I want, the above problem only affects pyls and that problem existed even before this PR.