Skip to content

Conversation

@novusnota
Copy link
Collaborator

Closes #1040

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes—index.mdx: a couple of style fixes; please apply the inline suggestions.

href="/contract-dev/carry-value"
cta="Carry-value pattern"
href="/contract-dev/first-smart-contract"
cta="Your first smart contract"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[HIGH] Second-person pronoun “your” introduced

The CTA label uses the second-person pronoun “Your” (“Your first smart contract”), which violates the style rule banning “you/your” in documentation. This line is part of the PR diff and introduces a [HIGH]-severity style issue. See the style rule “Don’t get personal” in https://github.com/ton-org/docs/blob/main/contribute/style-guide-extended.mdx?plain=1#L163-L166 for justification.

Suggested change
cta="Your first smart contract"
cta="First smart contract"

Please leave a reaction 👍/👎 to this suggestion to improve future reviews for everyone!

title="Your first TON dApp"
icon="mobile-notch"
<JourneyStep
title="Your first smart contract"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[HIGH] Second-person pronoun “your” introduced

The JourneyStep title uses the second-person pronoun “Your” (“Your first smart contract”), which violates the same style rule prohibiting “you/your”. This line is in the PR diff and therefore in scope. The rule “Don’t get personal” is documented at https://github.com/ton-org/docs/blob/main/contribute/style-guide-extended.mdx?plain=1#L163-L166.

Suggested change
title="Your first smart contract"
title="First smart contract"

Please leave a reaction 👍/👎 to this suggestion to improve future reviews for everyone!

@novusnota novusnota marked this pull request as draft October 30, 2025 12:09
@anton-trunov anton-trunov merged commit b995efe into main Oct 30, 2025
6 checks passed
@anton-trunov anton-trunov deleted the closes-1040/another-brick-in-the-wall branch October 30, 2025 12:24
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements. In index.mdx, I left a couple of suggestions; please apply the inline suggestions.

href="/contract-dev/carry-value"
cta="Carry-value pattern"
href="/contract-dev/first-smart-contract"
cta="Your first smart contract"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[HIGH] Second-person pronoun used in CTA label

The CTA label uses “Your first smart contract,” which addresses the reader directly. The style guide forbids using “you/your” to refer to the reader and marks this as HIGH severity (see contribute/style-guide-extended.mdx:163–166). Replace with a neutral label to comply with the documentation voice rules.

Suggested change
cta="Your first smart contract"
cta="First smart contract"

Please leave a reaction 👍/👎 to this suggestion to improve future reviews for everyone!

title="Your first TON dApp"
icon="mobile-notch"
<JourneyStep
title="Your first smart contract"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[HIGH] Second-person pronoun used in journey step title

The journey step title uses “Your first smart contract,” which violates the style rule against second-person pronouns (contribute/style-guide-extended.mdx:163–166). Use a neutral title to align with the documentation standards.

Suggested change
title="Your first smart contract"
title="First smart contract"

Please leave a reaction 👍/👎 to this suggestion to improve future reviews for everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update landing to match recent changes in the structure

3 participants