-
Notifications
You must be signed in to change notification settings - Fork 8
chore(landing): match recent changes in the structure #1050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -147,20 +147,20 @@ export const JourneyStep = ({ title, icon, iconType, href, cta, children }) => { | |||||||||
| </p> | ||||||||||
| </div> | ||||||||||
| <Columns cols={4}> | ||||||||||
| {/* <Card | ||||||||||
| title="Step-by-step guides" | ||||||||||
| icon="shoe-prints" | ||||||||||
| iconType="solid" | ||||||||||
| href="/guides/first-dapp" | ||||||||||
| cta="Your first dApp" | ||||||||||
| /> */} | ||||||||||
| <Card | ||||||||||
| title="Ecosystem" | ||||||||||
| icon="leaf" | ||||||||||
| iconType="solid" | ||||||||||
| href="/ecosystem/overview" | ||||||||||
| cta="Overview" | ||||||||||
| /> | ||||||||||
| <Card | ||||||||||
| title="Payment processing" | ||||||||||
| icon="wallet" | ||||||||||
| iconType="solid" | ||||||||||
| href="/payments/overview" | ||||||||||
| cta="Overview" | ||||||||||
| /> | ||||||||||
| <Card | ||||||||||
| title="Standard contracts" | ||||||||||
| icon="copy" | ||||||||||
|
|
@@ -169,11 +169,11 @@ export const JourneyStep = ({ title, icon, iconType, href, cta, children }) => { | |||||||||
| cta="Overview" | ||||||||||
| /> | ||||||||||
| <Card | ||||||||||
| title="Contract patterns" | ||||||||||
| title="Contract development" | ||||||||||
| icon="file-signature" | ||||||||||
| iconType="solid" | ||||||||||
| href="/contract-dev/carry-value" | ||||||||||
| cta="Carry-value pattern" | ||||||||||
| href="/contract-dev/first-smart-contract" | ||||||||||
| cta="Your first smart contract" | ||||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [HIGH] Second-person pronoun used in CTA labelThe CTA label uses “Your first smart contract,” which addresses the reader directly. The style guide forbids using “you/your” to refer to the reader and marks this as HIGH severity (see contribute/style-guide-extended.mdx:163–166). Replace with a neutral label to comply with the documentation voice rules.
Suggested change
Please leave a reaction 👍/👎 to this suggestion to improve future reviews for everyone! |
||||||||||
| /> | ||||||||||
| <Card | ||||||||||
| title="Languages" | ||||||||||
|
|
@@ -251,13 +251,13 @@ export const JourneyStep = ({ title, icon, iconType, href, cta, children }) => { | |||||||||
| iconType="solid" | ||||||||||
| href="/contract-dev/first-smart-contract" | ||||||||||
| /> | ||||||||||
| <JourneyStep | ||||||||||
| {/* <JourneyStep | ||||||||||
| title="What is a dApp?" | ||||||||||
| icon="5" | ||||||||||
| iconType="solid" | ||||||||||
| href="/foundations/glossary#decentralized-application-dapp" | ||||||||||
| /> | ||||||||||
| {/* <JourneyStep | ||||||||||
| <JourneyStep | ||||||||||
| title="Your first dApp on TON" | ||||||||||
| icon="6" | ||||||||||
| iconType="solid" | ||||||||||
|
|
@@ -276,14 +276,14 @@ export const JourneyStep = ({ title, icon, iconType, href, cta, children }) => { | |||||||||
| > | ||||||||||
| Compare the execution model and the ecosystem of TON | ||||||||||
| </JourneyStep> | ||||||||||
| {/* <JourneyStep | ||||||||||
| title="Your first TON dApp" | ||||||||||
| icon="mobile-notch" | ||||||||||
| <JourneyStep | ||||||||||
| title="Your first smart contract" | ||||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [HIGH] Second-person pronoun “your” introducedThe JourneyStep title uses the second-person pronoun “Your” (“Your first smart contract”), which violates the same style rule prohibiting “you/your”. This line is in the PR diff and therefore in scope. The rule “Don’t get personal” is documented at https://github.com/ton-org/docs/blob/main/contribute/style-guide-extended.mdx?plain=1#L163-L166.
Suggested change
Please leave a reaction 👍/👎 to this suggestion to improve future reviews for everyone! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [HIGH] Second-person pronoun used in journey step titleThe journey step title uses “Your first smart contract,” which violates the style rule against second-person pronouns (contribute/style-guide-extended.mdx:163–166). Use a neutral title to align with the documentation standards.
Suggested change
Please leave a reaction 👍/👎 to this suggestion to improve future reviews for everyone! |
||||||||||
| icon="file" | ||||||||||
| iconType="solid" | ||||||||||
| href="/guides/first-dapp" | ||||||||||
| href="/contract-dev/first-smart-contract" | ||||||||||
| > | ||||||||||
| From nothing to a deployed and working contract with a web frontend | ||||||||||
| </JourneyStep> */} | ||||||||||
| Write and deploy a contract that can be interacted with | ||||||||||
| </JourneyStep> | ||||||||||
| </Journey> | ||||||||||
| <Journey | ||||||||||
| title="Ace" | ||||||||||
|
|
@@ -308,7 +308,7 @@ export const JourneyStep = ({ title, icon, iconType, href, cta, children }) => { | |||||||||
| Complete list of instructions and opcodes | ||||||||||
| </JourneyStep> | ||||||||||
| <JourneyStep | ||||||||||
| title="RPC providers" | ||||||||||
| title="API providers" | ||||||||||
| href="/ecosystem/rpc/overview" | ||||||||||
| > | ||||||||||
| TON Center v2 and v3, and others | ||||||||||
|
|
||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[HIGH] Second-person pronoun “your” introduced
The CTA label uses the second-person pronoun “Your” (“Your first smart contract”), which violates the style rule banning “you/your” in documentation. This line is part of the PR diff and introduces a [HIGH]-severity style issue. See the style rule “Don’t get personal” in https://github.com/ton-org/docs/blob/main/contribute/style-guide-extended.mdx?plain=1#L163-L166 for justification.
Please leave a reaction 👍/👎 to this suggestion to improve future reviews for everyone!