-
Notifications
You must be signed in to change notification settings - Fork 21
feat(ci): add workflow to validate size and titles of pull requests, as well as number of linked issues #1487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sets the upper bound of additions to 500 in pull requests from forks, and to 1000 in PRs from direct branches. Not all additions are equal, as many generated, API or script files are ignored for clarity.
5c4629c to
8dd9789
Compare
|
Skipping AI review because no docs changes in md, mdx, or docs.json |
novusnota
commented
Nov 29, 2025
|
Skipping AI review because no docs changes in md, mdx, or docs.json |
verytactical
reviewed
Dec 1, 2025
verytactical
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1444.
Notice that
pull_request_targetworkflows run in the context of the base of the pull request, i.e., they use whatever's on themainbranch. Since this workflow isn't present there, it won't run in this PR.I've tested this CI with
pull_requesthere (worked for maintainers only), and then tested it in my own repo+fork playgrounds, where it worked for all PRs, whether from forks or not.Finally, notice the JavaScript examples right in the YAML — I cannot move them elsewhere under the premise that there should be no checkouts in
pull_request_targetworkflows to keep them secure. And no cache use either.It's quite easy to enable JS highlighting there in editors that operate on Tree-sitter, such as Zed or Helix (screenshot is outdated):