Skip to content

Conversation

@novusnota
Copy link
Collaborator

@novusnota novusnota commented Nov 29, 2025

Closes #1444.

Notice that pull_request_target workflows run in the context of the base of the pull request, i.e., they use whatever's on the main branch. Since this workflow isn't present there, it won't run in this PR.

I've tested this CI with pull_request here (worked for maintainers only), and then tested it in my own repo+fork playgrounds, where it worked for all PRs, whether from forks or not.

Finally, notice the JavaScript examples right in the YAML — I cannot move them elsewhere under the premise that there should be no checkouts in pull_request_target workflows to keep them secure. And no cache use either.

image

It's quite easy to enable JS highlighting there in editors that operate on Tree-sitter, such as Zed or Helix (screenshot is outdated):

image

@novusnota novusnota changed the title feat(ci): add a separate workflow to validate PR size in terms of additions feat(ci): add a separate workflow to validate PR size Nov 29, 2025
@novusnota novusnota changed the title feat(ci): add a separate workflow to validate PR size feat(ci): add workflow to (in)validate size of pull requests Nov 29, 2025
@novusnota novusnota changed the title feat(ci): add workflow to (in)validate size of pull requests feat(ci): add workflow to validate size of pull requests Nov 29, 2025
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Sets the upper bound of additions to 500 in pull requests from forks,
and to 1000 in PRs from direct branches. Not all additions are equal,
as many generated, API or script files are ignored for clarity.
@novusnota novusnota marked this pull request as ready for review November 29, 2025 05:27
@github-actions
Copy link

Skipping AI review because no docs changes in md, mdx, or docs.json

@novusnota novusnota changed the title feat(ci): add workflow to validate size of pull requests feat(ci): add workflow to validate size and some contents of pull requests Nov 29, 2025
@novusnota novusnota marked this pull request as draft November 29, 2025 06:16
@novusnota novusnota changed the title feat(ci): add workflow to validate size and some contents of pull requests feat(ci): add workflow to validate size and titles of pull requests, as well as number of linked issues Nov 29, 2025
@novusnota novusnota changed the title feat(ci): add workflow to validate size and titles of pull requests, as well as number of linked issues feat(ci): Aadd workflow to validate size and titles of pull requests, as well as number of linked issues Nov 29, 2025
@novusnota novusnota changed the title feat(ci): Aadd workflow to validate size and titles of pull requests, as well as number of linked issues feat(ci): Add workflow to validate size and titles of pull requests, as well as number of linked issues Nov 29, 2025
@novusnota novusnota changed the title feat(ci): Add workflow to validate size and titles of pull requests, as well as number of linked issues feat(ci): add workflow to validate size and titles of pull requests, as well as number of linked issues Nov 29, 2025
@novusnota novusnota marked this pull request as ready for review November 29, 2025 08:10
@github-actions
Copy link

Skipping AI review because no docs changes in md, mdx, or docs.json

@verytactical verytactical merged commit fb0252a into main Dec 1, 2025
8 checks passed
@verytactical verytactical deleted the closes-1444/bouncer.yml branch December 1, 2025 13:39
@novusnota novusnota added this to the Ownership transfer milestone Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] Bouncer

3 participants