Skip to content

Conversation

@aigerimu
Copy link
Contributor

@aigerimu aigerimu commented Oct 3, 2025

closes #572
closes #573
closes #574
closes #613

@aigerimu aigerimu requested a review from a team as a code owner October 3, 2025 19:13
@aigerimu aigerimu requested a review from verytactical October 3, 2025 19:13
@github-actions
Copy link

github-actions bot commented Oct 3, 2025

To fix the formatting issues:

  1. Install necessary dependencies: npm ci
  2. Then, run this command:
npx remark -o --quiet --silently-ignore ecosystem/explorers/tonviewer.mdx 

@github-actions
Copy link

github-actions bot commented Oct 3, 2025

To fix the formatting issues:

  1. Install necessary dependencies: npm ci
  2. Then, run this command:
npx remark -o --quiet --silently-ignore ecosystem/explorers/tonviewer.mdx 

@github-actions
Copy link

github-actions bot commented Oct 7, 2025

To fix the formatting issues:

  1. Install necessary dependencies: npm ci
  2. Then, run this command:
npx remark -o --silent --silently-ignore ecosystem/explorers/tonviewer.mdx 

@hacker-volodya hacker-volodya removed the request for review from a team October 7, 2025 18:58
@verytactical verytactical marked this pull request as draft October 10, 2025 15:38
@aigerimu aigerimu marked this pull request as ready for review October 13, 2025 05:50
@github-actions
Copy link

Thanks for the updates to the TON Viewer docs. A few high‑severity style and link integrity fixes are needed before merge, all in ecosystem/explorers/tonviewer.mdx.

Findings (3)

High (3)

[HIGH] Broken internal link to Blocks reference

Location: https://github.com/tact-lang/mintlify-ton-docs/blob/855a5c06f859e501679fdc13656db46a521657e5/ecosystem/explorers/tonviewer.mdx?plain=1#L18-L18

Description:
The “Blocks” bullet links to /ton/blocks, which does not exist in this repo. The canonical page is /ton/tblkch, and the base branch previously pointed there. This introduces a broken internal link.

Suggestion:

- - [Blocks](/ton/blocks) — containers of transactions. In explorers, they expose block metadata and configuration parameters, allowing you to trace activity and understand how the blockchain operates.
+ - [Blocks](/ton/tblkch) — containers of transactions. In explorers, they expose block metadata and configuration parameters, allowing you to trace activity and understand how the blockchain operates.

[HIGH] UI label not quoted per house rule

Location: https://github.com/tact-lang/mintlify-ton-docs/blob/855a5c06f859e501679fdc13656db46a521657e5/ecosystem/explorers/tonviewer.mdx?plain=1#L37-L37

Description:
The literal UI label Show details is emphasized in bold instead of being presented verbatim in double quotation marks. Per the style guide, UI/log strings must be quoted exactly and not emphasized.

Suggestion:

- - Use **Show details** to examine full transaction and message information.
+ - Use "Show details" to examine full transaction and message information.

[HIGH] Silent address truncation

Location: https://github.com/tact-lang/mintlify-ton-docs/blob/855a5c06f859e501679fdc13656db46a521657e5/ecosystem/explorers/tonviewer.mdx?plain=1#L111-L116

Description:
Two addresses are shown with ellipses (e.g., UQDj…D0lN, EQCo…gJdV) without noting they are truncated. The style guide requires explicitly indicating truncation to avoid misleading readers.

Suggestion:

- At point **A** (address `UQDj…D0lN`), the user’s wallet sends an external-in message to _transfer an NFT_.
+ At point **A** (address `UQDj…D0lN` (truncated)), the user’s wallet sends an external-in message to _transfer an NFT_.

- - B — the NFT contract at address `EQCo…gJdV`, validates ownership and executes the transfer.
+ - B — the NFT contract at address `EQCo…gJdV` (truncated), validates ownership and executes the transfer.

Copy link
Collaborator

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • fix merge conflicts
  • fix AI review
  • screenshots for light color theme needed
  • make the file names for dark and light theme screenshots consistent with the rest of the file names

@anton-trunov anton-trunov marked this pull request as draft October 22, 2025 21:12
@aigerimu aigerimu marked this pull request as ready for review October 24, 2025 14:55
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. There’s one inline suggestion in ecosystem/explorers/tonviewer.mdx:; please apply it.

@verytactical
Copy link
Collaborator

/review

@novusnota
Copy link
Collaborator

@verytactical
Copy link
Collaborator

We'll have to make a total rewrite of this article in the future.

@anton-trunov anton-trunov merged commit e67a092 into main Nov 4, 2025
4 checks passed
@anton-trunov anton-trunov deleted the tonviewer branch November 4, 2025 15:24
laviniat1996 pushed a commit that referenced this pull request Nov 5, 2025
aigerimu added a commit that referenced this pull request Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

5 participants