12 attribute gpkg metadata causes inconsistent hash #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a GeoPackage hashing instability issue by normalizing the last_change timestamp in GPKG files to Unix epoch. The GeoPackage format stores a last_change timestamp in the gpkg_contents table, which was causing identical GeoDataFrames written at different times to produce different hashes, breaking content-based versioning.
Key changes:
- Introduced
_snapshot_last_change()helper to set GPKGlast_changetimestamps to Unix epoch (1970-01-01T00:00:00Z) - Added test to verify hash stability across writes at different times
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/geopins/drivers/gdf/filetypes/gpkg.py | Added _snapshot_last_change() function and SQLite connection handling to normalize GeoPackage timestamps after writing |
| tests/geopins/drivers/gdf/filetypes/test_gpkg.py | Added test verifying pin_hash stability when writing identical data at different times |
nathanjmcdougall
approved these changes
Nov 10, 2025
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.