lib: import active_support before cherry-picking imports#77
Merged
1 commit merged intomasterfrom Oct 10, 2023
unknown repository
Merged
lib: import active_support before cherry-picking imports#771 commit merged intomasterfrom unknown repository
1 commit merged intomasterfrom
unknown repository
Conversation
With an update to `activesupport-7.1.0` downstream libraries using hcloud-ruby ran into exceptions in activesupport. This seems to be the case, because we do not import `active_support` before any other imports from `active_support`. According to the docs [1] one always has to first `require "active_support"`, which imports the code needed by activesupport itself. And then we can import actual functionality by importing `active_support/all`, `active_support/core_ext/hash/indifferent_access` or something else. [1] https://guides.rubyonrails.org/active_support_core_extensions.html#stand-alone-active-support
bastelfreak
approved these changes
Oct 10, 2023
ghost
marked this pull request as ready for review
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With an update to
activesupport-7.1.0downstream libraries using hcloud-ruby ran into exceptions in activesupport. This seems to be the case, because we do not importactive_supportbefore any other imports fromactive_support.According to the docs [1] one always has to first
require "active_support", which imports the code needed by activesupport itself. And then we can import actual functionality by importingactive_support/all,active_support/core_ext/hash/indifferent_accessor something else.[1] https://guides.rubyonrails.org/active_support_core_extensions.html#stand-alone-active-support