Add support for updating NSTableView rows#24
Merged
Conversation
This implements update and apply methods for NSTableView. It also moves BatchUpdate to a new file and keeps the initializers separate for each platform because of the different IndexPath properties that UITableView (row) and NSTableView (item) use.
Owner
|
This is great, thanks @interstateone! I'll add I have need of |
Author
|
Awesome, thanks! I just realized that I forgot to update the README in that commit. 😆 |
Owner
|
That's OK, I've done it in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements update and apply methods for NSTableView. It also moves BatchUpdate to a new file and keeps the initializers separate for each platform because of the different IndexPath properties that UITableView (row) and NSTableView (item) use.
This branch doesn't implement support for NSCollectionView or NSOutlineView because I don't have an immediate need for them, and so I don't have something built to test them with. NestedBatchUpdate could probably be moved as-is to BatchUpdate.swift in order to support NSCollectionView updates.