Always pick bestvideo, ignore extension#225
Merged
don-vip merged 1 commit intotoolforge:masterfrom Oct 4, 2024
Merged
Conversation
to fix https://commons.wikimedia.org/wiki/Commons_talk:Video2commons#c-Prototyperspective-20240930164100-Suddenly_imports_at_low_quality theoretically we can design a more complicated selection, by prioritising filesize then pick extension if there exists, but beyond my ability, so now just remove the "pick by extension" method for video tracks.
Collaborator
|
change deployed on encoding01/02/05/06 Still ongoing heavy jobs on encoding03/04, I wait for their completion. |
|
Great, thanks for the fix. I guess it gets converted to webm elsewhere in the code if the filetype is a WMC-incompatible one like mp4. |
Collaborator
|
yes, that's the whole point of v2c |
|
I find its copying of the video description and license at least as useful. If that wasn't the yt-dlp command that was changed (didn't check thoroughly) then |
Collaborator
|
change deployed on encoding03/04 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to fix https://commons.wikimedia.org/wiki/Commons_talk:Video2commons#c-Prototyperspective-20240930164100-Suddenly_imports_at_low_quality
theoretically we can design a more complicated selection, by prioritising filesize then pick extension if there exists, but beyond my ability, so now just remove the "pick by extension" method for video tracks.