Do not disallow question marks and other chars in URLs#349
Merged
Conversation
The title sanitization rules are too strict and disallow valid titles. It's possible the rules used to apply but the rules have since been changed. This patch isn't exhaustive and other rules may need to be amended. The new pattern has been adjusted to: * Allow '?' and '+' in the title as those are allowed on Commons * No longer check '\u0000-\u001f' and '\u007f' as those are already covered by earlier rules and are redundant * No longer check for '#', ':', and '/' as those are covered by other rules, though I'm unsure if those rules are even needed
Collaborator
|
I think we will start to need unit tests for this kind of checks :) |
don-vip
approved these changes
Mar 30, 2026
Collaborator
Author
|
Those would be nice to have for a few things |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The title sanitization rules are too strict and disallow valid titles. It's possible these rules used to make sense, but the rules have since been changed. This patch isn't exhaustive and other rules may need to be amended.
The new pattern has been adjusted to: