Modernizing packaging#127
Merged
marcosfrenkel merged 12 commits intotoolsforexperiments:masterfrom Apr 30, 2026
Merged
Conversation
Terminate zmq contexts on disconnect, close instrument tabs in window closeEvents so SubClient threads exit, make refreshStationComponents defensive against None, and misc dummy-instrument/conftest fixes so test_client_station and most of test_server_gui pass cleanly.
marcosfrenkel
force-pushed
the
modernizing_packaging
branch
from
b14d57f to
c8e0e63
Compare
marcosfrenkel
force-pushed
the
modernizing_packaging
branch
from
4f69fb8 to
32be17f
Compare
marcosfrenkel
force-pushed
the
modernizing_packaging
branch
from
10bb542 to
3cddf38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modernizes the project's Python packaging and tooling.
src/instrumentserver/(PEP 621 / src-layout).uv.pyproject.tomlrewritten with project metadata, scripts, optionalmonitoringdep, anddependency-groupsfordevanddocs.uv.lockchecked in.ruff(extend-select = ["I"]). Codebase passesuv run ruff check src/.mypywith strict-ish flags (strict_optional,disallow_untyped_defs,warn_unused_ignores, etc.).uv run mypypasses — see scope note below.test_base.py,test_client_station.py,test_config.py,test_helpers.py. Expandedtest_param_manager.py,test_json_serializable.py,test_server_gui.py. Hardened ZMQ/Qt teardown to prevent cross-test instrument leaks. 94 tests total.uv. Added aci.ymlworkflow runningruff+mypy+pytest(with xvfb for the Qt suite).ParameterBroadcastBluePrint.pprint()referenced a non-existentself.bp_typeattribute (caught by the type sweep); reference removed.Scope note: type-ignore comments
mypyis currently green at the cost of 208# type: ignorecomments insrc/. Cleaning these up is intentionally out of scope for this PR to keep the diff bounded. The full plan — root-cause buckets (A–N), four named structural problems, and a priority ordering targeting 208 → ~30 ignores — is tracked in a separate issue.Test plan
uv run ruff check src/exits 0uv run mypyexits 0uv run pytest— 94/94 passing (~49s)ci.ymlworkflow goes green on first push