Skip to content

Conversation

@toomuchdesign
Copy link
Owner

@toomuchdesign toomuchdesign commented Oct 29, 2025

What kind of change does this PR introduce?

Bug fix

What is the current behaviour?

sealSchemaDeep and sealSchemaDeep change the logical meaning of JSON Schema combinators such as allOf, anyOf, oneOf, or not.

What is the new behaviour?

Skip allOf, anyOf, oneOf, or not values

Does this PR introduce a breaking change?

No

Other information:

Please check if the PR fulfills these requirements:

  • Tests for the changes have been added
  • Docs have been added / updated
  • Relevant Changeset has been added

@changeset-bot
Copy link

changeset-bot bot commented Oct 29, 2025

🦋 Changeset detected

Latest commit: c38dde9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@toomuchdesign/json-schema-fns Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link

coveralls commented Oct 29, 2025

Pull Request Test Coverage Report for Build 18915039245

Details

  • 19 of 19 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 18912869219: 0.0%
Covered Lines: 73
Relevant Lines: 73

💛 - Coveralls

@toomuchdesign toomuchdesign force-pushed the fix-sealSchemaDeep-array-types branch from e412e85 to ea0f7d4 Compare October 29, 2025 15:41
@toomuchdesign toomuchdesign changed the title fix: skip JSON Schema combinators fix: deep methods skip JSON Schema combinators Oct 29, 2025
@toomuchdesign toomuchdesign changed the title fix: deep methods skip JSON Schema combinators fix: skip JSON Schema combinators in sealSchemaDeep and unsealSchemaDeep Oct 29, 2025
@toomuchdesign toomuchdesign merged commit 452602c into master Oct 29, 2025
3 checks passed
@toomuchdesign toomuchdesign deleted the fix-sealSchemaDeep-array-types branch October 29, 2025 22:33
toomuchdesign added a commit that referenced this pull request Oct 30, 2025
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to master, this PR
will be updated.


# Releases
## @toomuchdesign/json-schema-fns@0.6.1

### Patch Changes

- [#85](#85)
[`452602c`](452602c)
Thanks [@toomuchdesign](https://github.com/toomuchdesign)! -
`unsealSchemaDeep`: do not modify `allOf`, `anyOf`, `oneOf`, or `not`
values

- [#85](#85)
[`452602c`](452602c)
Thanks [@toomuchdesign](https://github.com/toomuchdesign)! -
`sealSchemaDeep`: do not modify `allOf`, `anyOf`, `oneOf`, or `not`
values

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants