fix(docker): add @toon-protocol/townhouse dep to docker package (Story 45.1 smoke-test fix)#38
Merged
ALLiDoizCode merged 1 commit intomainfrom May 9, 2026
Merged
Conversation
…kage esbuild couldn't resolve @toon-protocol/townhouse from the docker/ package context during the Dockerfile.townhouse-api build. Add workspace:* dep (matching the pattern for town, mill, dvm) and @types/dockerode for the Docker import in entrypoint-townhouse-api.ts. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Dockerfile.townhouse-api build failure
Smoke test run 25588317203 failed at the
Build and push multi-arch imagestep fortownhouse-api:Root cause:
docker/package.jsonlists workspace deps fortown,mill,dvmbut nottownhouse. esbuild runs from thedocker/package context and can't resolve@toon-protocol/townhousewithout the workspace link.Fix:
"@toon-protocol/townhouse": "workspace:*"todocker/package.jsondependencies (mirrors the pattern fortown,mill,dvm)"@types/dockerode": "^3.3.0"to devDependencies (needed for theimport Docker from 'dockerode'inentrypoint-townhouse-api.ts)pnpm-lock.yaml🤖 Generated with Claude Code