Skip to content

[doc,feat]: Add proper documentation and simplify autoposting#10

Merged
ffamilyfriendly merged 10 commits into
top-gg-community:mainfrom
null8626:main
Sep 23, 2024
Merged

[doc,feat]: Add proper documentation and simplify autoposting#10
ffamilyfriendly merged 10 commits into
top-gg-community:mainfrom
null8626:main

Conversation

@null8626
Copy link
Copy Markdown
Member

@null8626 null8626 commented Sep 20, 2024

The following pull request does the following:

  • Add documentation with Doxygen.
  • Simplify autoposting by making developers just use the start_autoposter() method.
  • Replace dpp::async<topgg::result<T>> in coroutine return types with topgg::async_result<T>.
  • Default to C++20 if DPP_CORO is enabled, C++17 otherwise.
  • Remove the unnecessary topgg::base_client abstract class.
  • Remove over-dependence on macros.
  • Add resource file containing library metadata for Windows.

Comment thread src/result.cpp Outdated
Comment thread topgg.rc
@null8626
Copy link
Copy Markdown
Member Author

cc @ffamilyfriendly

Copy link
Copy Markdown
Contributor

@ffamilyfriendly ffamilyfriendly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ffamilyfriendly ffamilyfriendly merged commit 8c2ec1d into top-gg-community:main Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants