Skip to content

Fix a bad copy paste#7

Closed
paris-ci wants to merge 1 commit into
top-gg:masterfrom
paris-ci:patch-1
Closed

Fix a bad copy paste#7
paris-ci wants to merge 1 commit into
top-gg:masterfrom
paris-ci:patch-1

Conversation

@paris-ci
Copy link
Copy Markdown

@paris-ci paris-ci commented Feb 9, 2021

The previous documentation was wrong there.

My test case :

❯ curl -X POST 'https://top.gg/api/bots/187636089073172481/stats' -H "Content-Type: application/json" -d '{"server_count":14122,"shards":[],"shard_count":14}' -H "Authorization: TOKEN"
{}

The previous documentation was wrong there.

My test case : 
```shell
❯ curl -X POST 'https://top.gg/api/bots/187636089073172481/stats' -H "Content-Type: application/json" -d '{"server_count":14122,"shards":[],"shard_count":14}' -H "Authorization: TOKEN"
{}
```
@ghost
Copy link
Copy Markdown

ghost commented Mar 1, 2021

The previous documentation was wrong there.

My test case :

❯ curl -X POST 'https://top.gg/api/bots/187636089073172481/stats' -H "Content-Type: application/json" -d '{"server_count":14122,"shards":[],"shard_count":14}' -H "Authorization: TOKEN"
{}

@paris-ci 1234 is a placeholder, and it's a good thing to know you'll get something like:

{
  "voted": 1
}

instead of just (nothing):

{}

@paris-ci
Copy link
Copy Markdown
Author

paris-ci commented Mar 1, 2021

Was that just changed ? I didn't see that response when testing.

@ghost
Copy link
Copy Markdown

ghost commented Mar 5, 2021

Was that just changed ? I didn't see that response when testing.

@paris-ci as i said 1234 is a placeholder and its useful to know what "things" you're going to get from the api :]

@paris-ci
Copy link
Copy Markdown
Author

paris-ci commented Mar 6, 2021

I don't understand what you mean. 1234 is written nowhere, and the returned json is an empty dict.

@Xetera
Copy link
Copy Markdown
Member

Xetera commented Mar 9, 2021

This doesn't make sense to me. Instead of changing the example response, we should be changing the example request in this case

@Xetera
Copy link
Copy Markdown
Member

Xetera commented Mar 9, 2021

Oh my bad I read the problem wrong. I think we should just remove the example response since this was a POST request and there isn't supposed to be a response that should be read/relied on in the first place

@Xetera
Copy link
Copy Markdown
Member

Xetera commented May 18, 2021

Fixed with #38

@Xetera Xetera closed this May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants