Skip to content
This repository was archived by the owner on Jan 4, 2020. It is now read-only.

Conversation

@blackpuppy
Copy link
Contributor

@blackpuppy blackpuppy commented Nov 18, 2018

  • 严格检查checkUrlMatch(...)返回值为false才表示动态路由未匹配成功
  • ruleCache(...)中读取路由配置应当避免改变路由定义顺序,因为顺序也会影响路由的解析
  • 既然DispatchergetModule(&$paths)getController(&$paths, $urlCase)getAction(&$paths, $urlCase)方法把&$paths当做堆栈用,就不应该在堆栈中的数据处理完之前中途重置堆栈
  • ruleCache(...)读取路由配置时,保持配置中路由定义的键的类型,以支持多个路由的路由表达式相同而路由参数不同的情况。在使用路由时,再处理键为整数索引的情况。

- 严格检查`checkUrlMatch(...)`返回值为`false`才表示动态路由未匹配成功
- `ruleCache(...)`中读取路由配置应当避免改变路由定义顺序,因为顺序也会影响路由的解析
- 确保为数组之后才能当数组使用
- 既然&$paths当做堆栈用,就不应该中途重置堆栈
- 用`ruleCache(...)`读取路由配置时,保持配置中路由定义的键的类型,以支持多个路由的路由表达式相同而路由参数不同的情况
- 在使用路由时,再处理键为索引的情况
@liu21st liu21st merged commit 40757e0 into top-think:master Dec 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants