Not all notifications are dismissed when the user visits the target page

[vic-georgiev]

Expected behavior

When I click/tap on a notification, and the target page loads, the notification should be dismissed.

Actual behavior

Currently works for posts, but not for project status, members joining a project, probably others. Let's try to unify the behavior of all notifications in the system to be the same.

Aha! Link: https://topcoder.aha.io/features/TCCONNECT-445

[maxceem]

Also, I see notifications are not dismissed for added a link to your project.

[vikasrohit]

@maxceem Do you think this issue is same as #2123?

[maxceem]

@vikasrohit Generally, they shouldn't be related. The code which was not working in #2123 is responsible for notifications which are connected to topcis/posts only. So explicitly that code didn't break other types of notifications.

Implicitly that issue can cause other issues, as it breaks the js code.

But to break other code some conditions has to be met. Only if during testing added a link to your project. notification, user also added some post which caused issue #2123 which breaks the js and breaks other types of notifications.

[gondzo]

We should implement this in a generic way so it's easy to extend when we add notifications for different target pages in the future (ex #2178).
IMO a good approach would be to listen for route changes in react-router and dismiss notifications that match current route. Any better ideas @vikasrohit ?

[vikasrohit]

Yep, handling it in a generic way would be good, however, I am not sure what exactly that would be. How are we dismissing the notifications right now?

IMO a good approach would be to listen for route changes in react-router and dismiss notifications that match current route

I am not sure if all notifications would have separate routes i.e. there might be multiple notifications sharing the same route, so it would be difficult to determine which notification has to be dismissed.

[gondzo]

Right now we dismiss notifications from dashboard and from messages feed, but using that approach won't scale (handling notifications in each specific route).

We should dismiss all notifications that have the same route - if we're dismissing one of them, then it makes sense to dismiss all of them. Ex - phase posts notifications - all of them lead to the same screen so we would dismiss all of them

[vikasrohit]

But wouldn't it dismiss notifications for all phases when there are posts in multiple phases and user clicks on one of the notifications.

[gondzo]

@vikasrohit yes, it would dismiss notifications for all phases with the above approach. Would it make sense to add some kind of 'event emitter' logic to components that display the target for a notification? For example we can have Feed container emit "message seen" event for each displayed message, files list component would emit "file seen" event for all seen files. Then we would have some main logic to process those 'events' and dismiss notifications.
any other ideas?