Warnings in developer console

[maxceem]

There are several warnings in browser console. Not something critical, but probably can find some time to clean them up.

1. Page http://local.topcoder-dev.com:3000/projects

   warning.js:33 Warning: Each child in an array or iterator should have a unique "key" prop. Check the render method of `GridView`. See https://fb.me/react-warning-keys for more information.
    in Placeholder (created by GridView)
    in GridView (created by ProjectsGridView)
    in div (created by ProjectsGridView)
    in ProjectsGridView (created by branch(ProjectsGridView))
    in branch(ProjectsGridView) (created by branch(branch(ProjectsGridView)))
    in branch(branch(ProjectsGridView)) (created by Projects)
    in div (created by Projects)
    in section (created by Projects)
    in div (created by Projects)
    in Projects (created by Connect(Projects))
    in Connect(Projects) (created by Route)
    in Route (created by withRouter(Connect(Projects)))
    in withRouter(Connect(Projects)) (created by AuthenticatedComponent)
    in div (created by AuthenticatedComponent)
    in AuthenticatedComponent (created by Route)
    in Route (created by withRouter(AuthenticatedComponent))
    in withRouter(AuthenticatedComponent) (created by Route)
    in div (created by Layout)
    in div (created by Layout)
    in Layout (created by Layout)
    in Layout (created by Connect(Layout))
    in Connect(Layout) (created by App)
    in App (created by Route)
    in Route (created by Route)
    in Switch (created by Route)
    in Route
    in Switch (created by Routes)
    in Routes (created by Route)
    in Route (created by withRouter(Routes))
    in withRouter(Routes)
    in Router (created by BrowserRouter)
    in BrowserRouter
    in GatewayProvider
    in Provider
    in AppContainer
   

2. Page http://local.topcoder-dev.com:3000/projects/6706/plan
   This warning actually because of not correct development backend data. Probably it should just stay as it's higlights the valid issue.

   Warning: Failed prop type: The prop `members[0].handle` is marked as required in `TeamManagement`, but its value is `undefined`.
   in TeamManagement (created by Uncontrolled(TeamManagement))
   in Uncontrolled(TeamManagement) (created by TeamManagementContainer)
   in div (created by TeamManagementContainer)
   in TeamManagementContainer (created by Connect(TeamManagementContainer))
   in Connect(TeamManagementContainer) (created by Route)
   in Route (created by withRouter(Connect(TeamManagementContainer)))
   in withRouter(Connect(TeamManagementContainer)) (created by ProjectInfoContainer)
   in div (created by ProjectInfoContainer)
   in div (created by ProjectInfoContainer)
   in ProjectInfoContainer (created by Connect(ProjectInfoContainer))
   in Connect(ProjectInfoContainer) (created by ProjectPlanContainer)
   in div (created by Sticky)
   in div (created by Sticky)
   in Sticky (created by MediaQuery)
   in MediaQuery (created by ProjectPlanContainer)
   in aside (created by Unknown)
   in Unknown (created by ProjectPlanContainer)
   in div (created by TwoColsLayout)
   in TwoColsLayout (created by ProjectPlanContainer)
   in ProjectPlanContainer (created by Connect(ProjectPlanContainer))
   in Connect(ProjectPlanContainer) (created by Route)
   in div (created by ProjectDetailView)
   in ProjectDetailView (created by branch(ProjectDetailView))
   in branch(ProjectDetailView) (created by branch(branch(ProjectDetailView)))
   in branch(branch(ProjectDetailView)) (created by ProjectDetail)
   in ProjectDetail (created by Connect(ProjectDetail))
   in Connect(ProjectDetail) (created by Route)
   in Route (created by withRouter(Connect(ProjectDetail)))
   in withRouter(Connect(ProjectDetail)) (created by Route)
   in Route
   in Switch
   in div (created by ProjectViewLayout)
   in ProjectViewLayout (created by AuthenticatedComponent)
   in div (created by AuthenticatedComponent)
   in AuthenticatedComponent (created by Route)
   in Route (created by withRouter(AuthenticatedComponent))
   in withRouter(AuthenticatedComponent) (created by withProps(withRouter(AuthenticatedComponent)))
   in withProps(withRouter(AuthenticatedComponent)) (created by Route)
   in div (created by Layout)
   in div (created by Layout)
   in Layout (created by Layout)
   in Layout (created by Connect(Layout))
   in Connect(Layout) (created by App)
   in App (created by Route)
   in Route (created by Route)
   in Switch (created by Route)
   in Route
   in Switch (created by Routes)
   in Routes (created by Route)
   in Route (created by withRouter(Routes))
   in withRouter(Routes)
   in Router (created by BrowserRouter)
   in BrowserRouter
   in GatewayProvider
   in Provider
   in AppContainer
   

3. Page http://local.topcoder-dev.com:3000/projects/6706/plan

   Warning: `value` prop on `input` should not be null. Consider using the empty string to clear the component or `undefined` for uncontrolled components.
   in input (created by TextInput)
   in div (created by TextInput)
   in TextInput (created by Formsy(TextInput))
   in Formsy(TextInput) (created by EditStageForm)
   in div (created by EditStageForm)
   in div (created by EditStageForm)
   in form (created by Formsy)
   in Formsy (created by EditStageForm)
   in div (created by EditStageForm)
   in div (created by EditStageForm)
   in EditStageForm (created by Connect(EditStageForm))
   in Connect(EditStageForm) (created by Route)
   in Route (created by withRouter(Connect(EditStageForm)))
   in withRouter(Connect(EditStageForm)) (created by MediaQuery)
   in div (created by MediaQuery)
   in div (created by MediaQuery)
   in MediaQuery (created by PhaseCard)
   in div (created by PhaseCard)
   in PhaseCard (created by Connect(PhaseCard))
   in Connect(PhaseCard) (created by ProjectStage)
   in ProjectStage (created by Uncontrolled(ProjectStage))
   in Uncontrolled(ProjectStage) (created by PhaseFeedContainer)
   in PhaseFeedContainer (created by Connect(PhaseFeedContainer))
   in Connect(PhaseFeedContainer) (created by ProjectStages)
   in section (created by Section)
   in Section (created by ProjectStages)
   in ProjectStages (created by Route)
   in Route (created by withRouter(ProjectStages))
   in withRouter(ProjectStages) (created by ProjectPlanContainer)
   in div (created by Unknown)
   in div (created by Unknown)
   in Unknown (created by ProjectPlanContainer)
   in div (created by TwoColsLayout)
   in TwoColsLayout (created by ProjectPlanContainer)
   in ProjectPlanContainer (created by Connect(ProjectPlanContainer))
   in Connect(ProjectPlanContainer) (created by Route)
   in div (created by ProjectDetailView)
   in ProjectDetailView (created by branch(ProjectDetailView))
   in branch(ProjectDetailView) (created by branch(branch(ProjectDetailView)))
   in branch(branch(ProjectDetailView)) (created by ProjectDetail)
   in ProjectDetail (created by Connect(ProjectDetail))
   in Connect(ProjectDetail) (created by Route)
   in Route (created by withRouter(Connect(ProjectDetail)))
   in withRouter(Connect(ProjectDetail)) (created by Route)
   in Route
   in Switch
   in div (created by ProjectViewLayout)
   in ProjectViewLayout (created by AuthenticatedComponent)
   in div (created by AuthenticatedComponent)
   in AuthenticatedComponent (created by Route)
   in Route (created by withRouter(AuthenticatedComponent))
   in withRouter(AuthenticatedComponent) (created by withProps(withRouter(AuthenticatedComponent)))
   in withProps(withRouter(AuthenticatedComponent)) (created by Route)
   in div (created by Layout)
   in div (created by Layout)
   in Layout (created by Layout)
   in Layout (created by Connect(Layout))
   in Connect(Layout) (created by App)
   in App (created by Route)
   in Route (created by Route)
   in Switch (created by Route)
   in Route
   in Switch (created by Routes)
   in Routes (created by Route)
   in Route (created by withRouter(Routes))
   in withRouter(Routes)
   in Router (created by BrowserRouter)
   in BrowserRouter
   in GatewayProvider
   in Provider
   in AppContainer
   

4. Open http://local.topcoder-dev.com:3000/projects/6706/plan and after switch to http://local.topcoder-dev.com:3000/projects/6706/scope there will be several warning depend on the quanity of phases:

   Warning: Formsy: isMounted is deprecated. Instead, make sure to clean up subscriptions and pending requests in componentWillUnmount to prevent memory leaks.
   

   As the reponsible code in another repository, I've listed a separate issue there Warning: Formsy: isMounted is deprecated. Instead, make sure to clean up subscriptions and pending requests in componentWillUnmount to prevent memory leaks. topcoder-platform/react-components#290

Aha! Link: https://topcoder.aha.io/features/TCCONNECT-289

[vikasrohit]

Included in next release.

[maxceem]

5. Project plan page http://local.topcoder-dev.com:3000/projects/6967/plan

    client:153 ./src/projects/detail/components/PhaseCard/EditStageForm.jsx
    364:20-36 "export 'syncPhases' (imported as 'syncPhasesAction') was not found in 
     '../../../actions/project'
     @ ./src/projects/detail/components/PhaseCard/EditStageForm.jsx
     @ ./src/projects/detail/components/PhaseCard/PhaseCard.jsx
     @ ./src/projects/detail/components/PhaseCard/index.js
     @ ./src/projects/detail/components/ProjectStage.jsx
     @ ./src/projects/detail/components/ProjectStages.jsx
     @ ./src/projects/detail/containers/ProjectPlanContainer.jsx
     @ ./src/projects/routes.jsx
     @ ./src/routes.jsx
     @ ./src/index.jsx
   

[maxceem]

6. When create a new Visual Design project on the wizard page http://local.topcoder-dev.com:3000/new-project/visual_design_prod there are three warnings:

   Warning: Failed prop type: The prop `addAttachment` is marked as required in `SpecSection`, but its value is `undefined`.`
   Warning: Failed prop type: The prop `updateAttachment` is marked as required in `SpecSection`, but its value is `undefined`.
   Warning: Failed prop type: The prop `removeAttachment` is marked as required in `SpecSection`, but its value is `undefined`.
   

[maxceem]

7. Create a new Visual Design project. There will be one phase. Complete all the milestones adding final fixes. When we click complete at final fixes milestone there will be in console:

   warning.js:33 Warning: flattenChildren(...): Encountered two children with the same key, `1:$2110`. Child keys must be unique; when two children share a key, only the first child will be used.
    in div (created by Timeline)
    in Timeline (created by ProductTimelineContainer)
    in ProductTimelineContainer (created by Connect(ProductTimelineContainer))
    in Connect(ProductTimelineContainer) (created by ProjectStage)
    in div (created by ProjectStage)
    in div (created by MediaQuery)
    in div (created by MediaQuery)
    in MediaQuery (created by PhaseCard)
    in div (created by PhaseCard)
    in PhaseCard (created by Connect(PhaseCard))
    in Connect(PhaseCard) (created by ProjectStage)
    in ProjectStage (created by Uncontrolled(ProjectStage))
    in Uncontrolled(ProjectStage) (created by PhaseFeedContainer)
    in PhaseFeedContainer (created by Connect(PhaseFeedContainer))
    in Connect(PhaseFeedContainer) (created by ProjectStages)
    in section (created by Section)
    in Section (created by ProjectStages)
    in ProjectStages (created by Route)
    in Route (created by withRouter(ProjectStages))
    in withRouter(ProjectStages) (created by ProjectPlanContainer)
    in div (created by Unknown)
    in div (created by Unknown)
    in Unknown (created by ProjectPlanContainer)
    in div (created by TwoColsLayout)
    in TwoColsLayout (created by ProjectPlanContainer)
    in ProjectPlanContainer (created by Connect(ProjectPlanContainer))
    in Connect(ProjectPlanContainer) (created by Route)
    in div (created by ProjectDetailView)
    in ProjectDetailView (created by branch(ProjectDetailView))
    in branch(ProjectDetailView) (created by branch(branch(ProjectDetailView)))
    in branch(branch(ProjectDetailView)) (created by ProjectDetail)
    in ProjectDetail (created by Connect(ProjectDetail))
    in Connect(ProjectDetail) (created by Route)
    in Route (created by withRouter(Connect(ProjectDetail)))
    in withRouter(Connect(ProjectDetail)) (created by Route)
    in Route
    in Switch
    in div (created by ProjectViewLayout)
    in ProjectViewLayout (created by AuthenticatedComponent)
    in div (created by AuthenticatedComponent)
    in AuthenticatedComponent (created by Route)
    in Route (created by withRouter(AuthenticatedComponent))
    in withRouter(AuthenticatedComponent) (created by withProps(withRouter(AuthenticatedComponent)))
    in withProps(withRouter(AuthenticatedComponent)) (created by Route)
    in div (created by Layout)
    in div (created by Layout)
    in Layout (created by Layout)
    in Layout (created by Connect(Layout))
    in Connect(Layout) (created by App)
    in App (created by Route)
    in Route (created by Route)
    in Switch (created by Route)
    in Route
    in Switch (created by Routes)
    in Routes (created by Route)
    in Route (created by withRouter(Routes))
    in withRouter(Routes)
    in Router (created by BrowserRouter)
    in BrowserRouter
    in GatewayProvider
    in Provider
    in AppContainer
   

   Update looks like this warining is being shown after completing any milestone.

[vikasrohit]

Good capture this one again @maxceem I noticed that yesterday but again due to enormous amount of moving things, didn't get time to log it.

I have also noticed that it is firing PHASE_DIRTY_UNDO multiple times (exactly equal to the number of phases in the project) when we mark a milestone complete. And that is getting fired from componentWillUnmount method of EditStageFrom.jsx. So, I think we need to stop re-rendering of other phases except the one where milestone is updated. I know that would be tricky, but I think we need to do it asap after the release.

[maxceem]

9. When creating a new Visual Design project and start typing the project title or REF code

    Warning: TextInput is changing an uncontrolled input of type undefined to be controlled. Input elements should not switch from uncontrolled to controlled (or vice versa). Decide between using a controlled or uncontrolled input element for the lifetime of the component. More info: https://fb.me/react-controlled-components
   

[maxceem]

10. When open one project http://local.topcoder-dev.com:3000/projects/7239 then without reloading page navigate to project list and after to another project http://local.topcoder-dev.com:3000/projects/7238 (by clicking it in th project list), warning two times:

    warning.js:33 Warning: Failed prop type: The prop `members` is marked as required in `TeamManagementContainer`, but its value is `undefined`.
    in TeamManagementContainer (created by Connect(TeamManagementContainer))
    in Connect(TeamManagementContainer) (created by Route)
    in Route (created by withRouter(Connect(TeamManagementContainer)))
    in withRouter(Connect(TeamManagementContainer)) (created by ProjectInfoContainer)
    in div (created by ProjectInfoContainer)
    in div (created by ProjectInfoContainer)
    in ProjectInfoContainer (created by Connect(ProjectInfoContainer))
    in Connect(ProjectInfoContainer) (created by DashboardContainer)
    in div (created by Sticky)
    in div (created by Sticky)
    in Sticky (created by MediaQuery)
    in MediaQuery (created by DashboardContainer)
    in aside (created by Unknown)
    in Unknown (created by DashboardContainer)
    in div (created by TwoColsLayout)
    in TwoColsLayout (created by DashboardContainer)
    in DashboardContainer (created by Connect(DashboardContainer))
    in Connect(DashboardContainer) (created by Route)
    in div (created by ProjectDetailView)
    in ProjectDetailView (created by branch(ProjectDetailView))
    in branch(ProjectDetailView) (created by branch(branch(ProjectDetailView)))
    in branch(branch(ProjectDetailView)) (created by ProjectDetail)
    in ProjectDetail (created by Connect(ProjectDetail))
    in Connect(ProjectDetail) (created by Route)
    in Route (created by withRouter(Connect(ProjectDetail)))
    in withRouter(Connect(ProjectDetail)) (created by Route)
    in Route
    in Switch
    in div (created by ProjectViewLayout)
    in ProjectViewLayout (created by AuthenticatedComponent)
    in div (created by AuthenticatedComponent)
    in AuthenticatedComponent (created by Route)
    in Route (created by withRouter(AuthenticatedComponent))
    in withRouter(AuthenticatedComponent) (created by withProps(withRouter(AuthenticatedComponent)))
    in withProps(withRouter(AuthenticatedComponent)) (created by Route)
    in div (created by Layout)
    in div (created by Layout)
    in Layout (created by Layout)
    in Layout (created by Connect(Layout))
    in Connect(Layout) (created by App)
    in App (created by Route)
    in Route (created by Route)
    in Switch (created by Route)
    in Route
    in Switch (created by Routes)
    in Routes (created by Route)
    in Route (created by withRouter(Routes))
    in withRouter(Routes)
    in Router (created by BrowserRouter)
    in BrowserRouter
    in GatewayProvider
    in Provider
    in AppContainer
    

[maxceem]

This is done. I don't see any warning which are shown in red now.

1. fixed
2. cannot reproduce (it was a valid warning and looks like the cause was fixed)
3. cannot reproduce
4. fixed by PR 291 to react-components
5. cannot reproduce (was fixed)
6. fixed
7. cannot reproduce (looks like fixed by other changes)
8. cannot reproduce (regarding PHASE_DIRTY_UNDO, looks like fixed by other changes)
9. fixed
10. fixed

[vikasrohit]

Not able to see any console error after quick testing around the project plan flows. Closing. Good work @maxceem