Refactor the way we are storing project template id while creating project

[vikasrohit]

This is a refactoring task to get rid of accessing details.products[0] to store the id of the template selected for a new project. It is also storing wrong value (project template key instead of product id) in this field which is causing projects created via logged out flow to fail to load.

fyi @maxceem @RishiRajSahu

Aha! Link: https://topcoder.aha.io/features/TCCONNECT-366

[vikasrohit]

@maxceem @RishiRajSahu please let me know you guys see any issue with the PR. I am bit unsure how it would impact the other parts of the application. I have tested the straight forward use cases and they are working fine. I am more worried about the edge cases e.g. rendering of legacy projects or project creation failing after specific user movements in the wizard.

[maxceem]

@vikasrohit I'll take a look at changes and test it to make sure we are sage here.

[maxceem]

@vikasrohit I've checked everything that could be affected by the changes and everything works well for me.

There is just only one enhancement comment: #2397 (review)

And one small issue:

• Icons in the project list are not rendered properly for new projects

  

  See lines https://github.com/appirio-tech/connect-app/blob/feature/refactoring-way-to-store-template-id/src/projects/list/components/Projects/ProjectsGridView.jsx#L54-L55

  Note, there is a related issue, but I thinkg it's not the same, as the next issue happenes before this change, but probably both of these issues have the same solution [$50] Website project icon is incorrect #2395

Let me know if you'd like me to fix it or you want to take care about it youreself.

[vikasrohit]

Thanks @maxceem for the review. I think icon issue would be fixe with this PR itself because we were storing the project template key instead of a product key in details.products. Still if this PR does not work for that, I would ask the competitor on #2395 to take latest from dev before applying fix again.

[vikasrohit]

Closing the issue as changes are deployed to the dev env and seems to work fine.