Error when making phase 'in progress'

[maxceem]

Sometimes when I switch phase to in progress status, I get error in browsers console:

productsTimelines.js:133 Uncaught (in promise) TypeError: Cannot read property '-1' of undefined
    at eval (productsTimelines.js:133)
    at eval (index.js:11)
    at eval (index.js:49)
    at dispatch (applyMiddleware.js:37)
    at optionallyUpdateFirstMilestone (project.js:417)

Error in the next line:

The error happens during attempt to mark the first milestone as active. After that we end up when phase is already in progress but there is no active milestone.

This error happens occasionlly.

Aha! Link: https://topcoder.aha.io/features/TCCONNECT-382

[vikasrohit]

Yes, it happened to me in dev last week. I thought that was happening because of timeline not being immediate visible after creation of the phase, which I think we get rid of with reading the timeline from timeline create call itself rather than making a separate call to load the timeline again. It seems now that is not exactly the reason, however, still it might because of missing timeline (may be state is not updated properly) OR empty milestones.
Anyway good to capture.

[maxceem]

This happened every time when we create a new Visual Design project and mark the only one default phase as in progress.

Fixed via e51ef01

[vikasrohit]

Good observation @maxceem. I can understand that update timeline call does not return milestones in response, which seems to the issue here, however I am still wondering why it was not happening for other type of projects/phases.

[maxceem]

@vikasrohit The reason is that after updating phase we update timeline only in case when phase start date is changed or phase is activated https://github.com/appirio-tech/connect-app/blob/dev/src/projects/actions/project.js#L421

[vikasrohit]

Yup, Agreed, but it still does not answer that why it was happening only for a specific type of project or phase.

[maxceem]

I didn't check for other project types, but I believe it has to happen for all types. I've mentioned the type of project in the issue just to be sure that the issue can be reproduced with my instructions.

…

On Thu, Aug 23, 2018, 14:35 vikasrohit ***@***.***> wrote: Yup, Agreed, but it still does not answer that why it was happening only for a specific type of project or phase. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2416 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAI6YO_T281t_fJR-mcWYtGnC-5eGwYIks5uTk0ZgaJpZM4WHaYj> .

[vikasrohit]

👍

[vikasrohit]

Working fine. Closing.