Add notification visual cues to phase timeline tab

[maxceem]

This is the second part of this issue #2401

Add the red dot to highlight that Timeline has some updates.
When we open such tab we have to mark the related notifications as read and hide the red dot as we already saw the updated content.

This issue requires support of additional event types which is tracked by the next issue #2426

continued from #2301

Update: Restricting the scope of the issue to timeline tab only. We would handle the specification tab separately later as that tab might be revamped soon or later.

Aha! Link: https://topcoder.aha.io/features/TCCONNECT-408

[maxceem]

@RishiRajSahu
I've tried to run connect-app using branch https://github.com/appirio-tech/connect-app/tree/feature/plan-timeline-events-settings where new notifications are implemented.

But new notifications never come when I activate phases or complete milestones by manager user and check for notifications by customer user. I used this project for testing http://local.topcoder-dev.com:3000/projects/7279

Is there any chance these events weren't added to Kafka, or currently some version of tc-project-service deployed which doesn't support these events yet?

[RishiRajSahu]

@maxceem yes there could be two possibilities -

• These events weren't added to kakfa
• Notifications service is not able to listen to kafka

I have to check, will let you know soon.

[vikasrohit]

@maxceem I am able to see the phase completed/activation and milestone completed/activation web notifications for my project when I perform the action as copilot and check the notifications as customer.

[maxceem]

To sum up.

The whole list of notification types when we have to add a cue to Timelines tab is:

• connect.action.timeline.adjusted
• connect.action.timeline.milestone.transition.active
• connect.action.timeline.milestone.transition.completed
• connect.action.timeline.milestone.waiting.customer

All of these notififications with mentioned types we will mark as read when we open Timelines tab.

So far it can be implemented similar way as it done now for Discussions tab.

[RishiRajSahu]

@maxceem yeah the list looks good, however other than above events, i found few milestones events as well -
connect.action.timeline.milestone.added NOT NEEDED
connect.action.timeline.milestone.removed NOT NEEDED
connect.action.timeline.milestone.updated NEEDED

out of which we can use connect.action.timeline.milestone.updated for showing timeline cue, as for remaining two we haven't yet provided any functionality yet on UI.

[maxceem]

@RishiRajSahu as far as I see neither of these events are now handled by tc-notifications https://github.com/topcoder-platform/tc-notifications/blob/dev/connect/constants.js or connect-app https://github.com/appirio-tech/connect-app/blob/dev/src/routes/notifications/constants/notifications.js

connect.action.timeline.milestone.added
connect.action.timeline.milestone.removed
connect.action.timeline.milestone.updated

So I guess before handling this issue we have to add them there. Correct?

[vikasrohit]

Yes, @maxceem we need to listen events and store in database before they can reach to connect app. And that is the tricky part, because we don't want to show these notifications in connect app.