[$30] Remove extension request for under review milestones

[RishiRajSahu]

Extension can't be requested during design review. Please remove the button while we're in review.

Please check all milestones which could be in review state to be consistent.

#2301

Aha! Link: https://topcoder.aha.io/features/TCCONNECT-454

[maxceem]

Ok, so there are two milestone types for design review final-designs, shown on the screenshot above and checkpoint-review which looks like this:

Note, that only user with manager privilages like phase_manager can see this button for the extension.

[RishiRajSahu]

@vic-topcoder do you meant to hide it for all roles ?

[maxceem]

@RishiRajSahu FYI, just to be clear, customer doesn't have button for extension at all.

[vikasrohit]

@RishiRajSahu @maxceem Hold on this.

@vic-topcoder @acshields I do not understand this requirement. It is common for getting the review phase extended in our delivery process and this happens when there are number of submissions are too high for the reviewers to review in time. So, I don't think we should remove the ability of extending the review milestone here.

[vic-georgiev]

@acshields - this is a question about process. Please correct me if I'm wrong, but we don't want to add extensions to customer-specific interaction. The customer just HAS to do the selection, they can't ask for extension, as we record WHEN they did the selection. So - for selecting designs, there is no extension for any user role.

[acshields]

I would agree, @vic-topcoder

[Gauravseta]

@maxceem any more open for pickup anytime soon? thanks

[maxceem]

@Gauravseta We don't plan to open for pick issues soon as current Bug Bash is almost finished.

[vikasrohit]

@vic-topcoder @acshields first thing is that we are not showing the Request Extension button for customers. And the reason why managers/copilots might need the extension button is that we are using the checkpoint-review and final-designs milestones in two different ways, one is where we are asking manager/copilot to add the design links to review and another where we add add-links milestone before these milestones. So, in first case we have the probability of manager asking extension because he/she is not able to collect all the designs for review because of the delay in the challenge.

That being said, I think for closing this issue, I have a solution. @RishiRajSahu @maxceem we should hide this button specifically for checkpoint-review and final-designs milestones when we are waiting for customer input (i.e. the flag waitingForCustomer is set to true which we are implementing via #2471 ). In that way even manager/copilots won't see this button if there is a add-links milestone before these milestone and it would be visible to them if they have to add the links in this milestone itself.