[$40] Allow editing link for final deliverable

[RishiRajSahu]

Links are not editable once the delivery is completed, but they should be. What would happen if a copilot moves things after they've completed adding links, and there's an error? Keep the option to edit/remove links for manager/copilots/admins at all times.

continued from #2301

Aha! Link: https://topcoder.aha.io/features/TCCONNECT-461

[RishiRajSahu]

@vic-topcoder can we have some UI cue for final deliverable link to give user an intuition of editing capability ?

[vic-georgiev]

@acshields - this is more of a product question - should we allow managers to modify links after delivery to customer?

I think from UX perspective you should keep the editing capability to allow for error recovery. This means keep the same editing mode - pen icon to the right of the link.

[acshields]

I think its fine to have the ability to modify links after delivery to the customer. Is a notification triggered to the customer regarding changed links, even after the project is complete? @vikasrohit @vic-topcoder

[vic-georgiev]

I'm not sure if we cover any timeline events with notifications. @vikasrohit ?

[vikasrohit]

@acshields @vic-topcoder we are incorporating timeline and milestone events in upcoming release, however, those will be limited to milestone completion, milestone activation and milestone waiting for customer input events. It requires more analysis and discussions to raise events on data modification of already completed milestones because it might trigger too many notifications to the customers and we have to very specific when detecting changing in data of milestone which would require highly coupled code which in turn is always difficult to maintain.
However, we would still analyze it in future releases.

fyi @RishiRajSahu

[vic-georgiev]

I would think that if a final deliverable link is updated there's a reason for it. Not sure if we're actually changing the package (new version of deliverables - have to notify customer) or just changing the location (same package - customer doesn't need a notification). For the time being, let's not add the notification on editing the final deliverable link. Just focus on making the link editable.

[acshields]

I am good with your proposal above @vic-topcoder

[vikasrohit]

@RishiRajSahu unblocked the issue as requirements are clear now.

To reiterate, we are not going to send notifications for change in deliverables for now.