Final fixes for "Topcoder Connect - Avatar and user settings" challenge

[maxceem]

We've got the submission for the challenge https://www.topcoder.com/challenges/30072639

Note, that we have another version of the submission from the participant via email, not the one in the system, as there some issue suppose to be fixed.

The issues reported by Rishi after testing submission from the system:

• when the request fails for updating the profile page, the page fields become empty

• notification settings page has different width than other two pages

• [cannot reproduce] unable to update the profile from local machine, getting error with trait, bad params

• Multiple network calls failure while loading project listing page

  

This list is constantly updating with new found issues:

• When we change something in My Profile and after press Save Settings. Data in the form for some time come to the state before changes, see the screencast https://monosnap.com/file/apnOUml0IaogWJDC5jCJfncAcDxtfX

• During uploading of user avatar even though the button looks disabled we can press it and choose another file to upload.

• Email validation and ressetting password don't work on DEV, as use wrong API URLs.

• Connect logo is a little bit down (not vertically centered) on the setting pages Top Bar

• Replace hardcoded colors with constants, also refer to New color variables in Connect App #2632

• When trying to change email server returns error. Same happens for community app on topcoder-dev.com

   {
      "id": "57e47e89:1669bc7e055:-7054",
      "result": {
          "success": true,
          "status": 500,
          "metadata": null,
          "content": "Cannot marshall type class com.appirio.service.member.api.Achievement without a custom marshaler or @DynamoDBDocument annotation."
      },
      "version": "v3" 
   }
  

• [server side issue]
  Every time we try to retrieve traits for other than logging in user using https://api.topcoder-dev.com/v3/members/pshah_customer/traits
  Server responds with Error 403:

    {
       "id": "57e47e89:1669bc7e055:-6fcb",
       "result": {
          "success": true,
          "status": 403,
          "metadata": null,
          "content": "The login user must be administrator"
        },
        "version": "v3" 
   }
  

• Save settings button has to be disabled if there are no changes. It has to be also done for Notifications settings page.

[maxceem]

unable to update the profile from local machine, getting error with trait, bad params

@RishiRajSahu Cannot reproduce using the latest submission patch provided by the winner. Check branch https://github.com/appirio-tech/connect-app/tree/feature/avatar-and-user-profile-settings or current PR #2655 for updated code.

[maxceem]

@RishiRajSahu one thing to discuss. We can update connect users' First and last name. But everywhere in the Connect app we are showing user names from the basic info. I guess we have to resolve it somehow.

[RishiRajSahu]

1.For team management view, we will still use the same old ES endpoint, as we can't fetch data of other users traits(we are not going to make multiple calls which we planned earlier), drawback is user won't be able to see connect_info related data on avatars of other team members. This could only be fixed once we have new endpoint supported by member-service which give data based on connect_info trait
2.For the logged-in user we will be using the data from the connect_info trait everywhere in the project
3.Regarding first and last name concern you mentioned, I think we are good until we are following point 1, because we are not worried about other users names until they are coming from

Below will be the behaviour of connect app after above things in place -

1.My Profile - will be working fine
2.Account and Security Page - will be working fine
3. User Avatar in top tool bar and logged in user avatar info - will be working fine
4.Team Management View & member avatars(firstName, lastName, Handle, PhotoUrl) - Data from old member profile endpoint will be shown only and not from the connect_info trait as we can't make api calls to get trait data of another user , this we earlier thought of fetching via making an individual api calls which is not possible for non-admin users
5. Projects listing page - old data for user avatars due to same reason as point 4

Con - logged-in user not able to see the connect_info related data(firstName, lastName, Handle, PhotoUrl) of other team member if they have updated it or have it different from the basic_info

fyi - Old member profile endpoint data is in sync with basic_info trait

@maxceem @vikasrohit @vic-topcoder @acshields