Console error on api 403

[gondzo]

Accessing a project that I don't have permissions to see used to show the coder bot error screen with details. Now it throws a console error and loading spinner is always shown. Here is an example in prod

[maxceem]

Thanks @gondzo ! I'm looking into it, so far very strange...

[maxceem]

@RishiRajSahu @vikasrohit

It's fixed and hotfix PRs provided

• PROD [HOTFIX] [PROD] for issue #2683 - show proper error message when error happens during project loading #2684
• DEV [HOTFIX] [DEV] for issue #2683 - show proper error message when error happens during project loading  #2685

The reason

The error happens here due to unreliable order of rendering ProjectDetail and DashboardContainer components in the the next code:

   <ProjectDetail>
      <DashboardContainer />
   </ProjectDetail>

ProjectDetail should prevent DashboardContainer to be rendered at all, if there is error during project loading. But as DashboardContainer is connected to the store using connect() function, it could happen that DashboardContainer is rendered first, so ProjectDetail couldn't stop it to be rendered in such cases, see a related issue in react-redux reduxjs/react-redux#509.

To make sure that rendering order doesn't depend on any side conditions, I've refactored the code.

[RishiRajSahu]

Closing. Merged to dev and prod