[$60] Checking balancing of parenthesis for conditions in parser

[RishiRajSahu]

Expected behavior

Parenthesis should always be balanced for conditions passed to the parser otherwise it will give wrong records. Parser itself should check for this before starting evaluating the condition.

Actual behavior

Currently it assumes that the condition always has balanced parenthesis.

fyi @maxceem @vikasrohit

[maxceem]

@RishiRajSahu what do you think should happened if parser finds out that parenthesis are not balanced?

• just log error and return undefined as a result of operation so other functionality is not broken? (easier)
• or throw error and code which uses it should take care about catching exception? (more correct way)

[RishiRajSahu]

@maxceem I also more inclined toward throwing error and blocking because hiding it via undefined might sometime result in false positive scenarios and make the dependent question feature for project form buggy. So, If we have error thrown we should/would discover it during testing in dev.

[maxceem]

Sum up:

• function evaluate() should check that parenthesis are balanced
• we should create unit tests with examples of expression with unbalanced parenthesis and check that function throws an error. (Try to provide helpful information about error position in the expression if possible).

[sumitdaga]

@maxceem
please asign it to me!

[maxceem]

done

[sumitdaga]

@maxceem
https://github.com/appirio-tech/connect-app/blob/dev/src/helpers/dependentQuestionsHelper.js#L26
the stack class's pop function has an issue ...it does not update the items property of the class ...i am using the stack class to print the indexes of unbalanced parens and thus noticed the issue ..
i will fix it as part of this issue ?

actually, any reason why we needed a custom Stack class ? ... a javascript array also has push, pop , etc methods ?