[$75] Inviting Topcoder member who is part of customer team is not showing error alert

[RishiRajSahu]

Expected behavior

When inviting existing project member to team it should show error alert.

Actual behavior

When inviting existing project member to team is not showing error alert.

Steps to reproduce the problem

• Invite customer via the email ID
• customer gets the notifications and join the topcoder and the project team
• Later you decide to add that customer to project team as manager, so try creating invite using handle (as customer is now registered on topcoder and has 'Connect Manager' role), the invite request ends successfully without showing any error alert like 'Team members can't be invited again'

Environment

• OS:any
• Browser (w/version):any
• User role (client, copilot or manager):manager

[maxceem]

It looks like this issues can generalised to the next one:

1. When we invite a member and after we are trying to invite it again in the same dialog, we get an error as expected:

   

2. But if we invited one member in one dialog and after we invite a member again in another dialog, we don't get an error (note: we have pshah_copilot invited in customer team at them moment):

   

3. If user is already a member, we can still invite him to the same team, but we should get an error message Team members can't be invited again

   

4. We also can invite an existent member to another team, but should get an error message instead:
   (note: we have pshah_copilot as a member in customer team at them moment)

   

So the case 1 already works. And we should fix cases 2-4 to show error the same way.

[maxceem]

@RishiRajSahu I think we can check all these cases client-side and show validation error just inside the popup rather than alert, what do you think?

[RishiRajSahu]

@maxceem yep we need to handle the cases mentioned, I too meant the error alert inside the popup(which we are seeing in 1.). Feel free to modify the language.

[omegatao]

I will take this one

[maxceem]

@omegatao it's on you since you commented as per our Bug Bash rules. To keep it clear I can assign you to this issue in the UI. For this, please accept the invitation to this repository which you should get to your email.