[$100] Enable editing the name of the milestone even if it is completed

[vikasrohit]

Expected behavior

We should allow editing of text for a milestone even if it is completed.

Actual behavior

As of now we don't allow updating anything for a completed milestones.

fyi @maxceem @RishiRajSahu

[maxceem]

@vikasrohit here are all the fields which we can edit for milestones which are not yet complete:

Just want to confirm. Which fields should we be able to edit when a milestone is complete?

1. Only Name
2. Only Name and Completed text
3. All fields but Duration
4. All fields

[vikasrohit]

@maxceem from the screenshot, all fields but Duration. Can we put validation on the backend as well for the same?

[maxceem]

@vikasrohit sure.

This task has two parts which have to be done: client-side and server-side.

1. [Client-side] We should show edit button for milestones for users who have rights to edit them event after milestone is complete. For example, pshah_manager can edit milestones, but pshah_customer cannot.
   When a milestone is completed, we can edit all the fields except ofDuration, in other statuses we should be able to edit all the fields as it's done now.

2. [Server-side] We should add validation server-side.

   • This task has to be done in https://github.com/topcoder-platform/tc-project-service
   • Create a PR against branch server-cf17 in tc-project-service.
   • We should update milestone update endpoint https://github.com/topcoder-platform/tc-project-service/blob/server-cf17/src/routes/milestones/update.js#L65
   • If user is trying to update duration field for a milestone which status is completed we should return an error code 422, message Duration cannot be updated for already completed milestone.
   • create a unit test which would validate this case

[PrakashDurlabhji]

@maxceem I wish to work on this

[maxceem]

sure