Correctly calculate local time for members taking into account "Daylight Saving Time"

[maxceem]

Follow up form the issue #3457:

The issue is caused by the fact, that New Your supports "Daylight Saving Time", so the timezone offset vary during the year from GMT-4 to GMT-5:

While we are using static list of timezones with respective time shifts:

So we have to use a smarter way to calculate the current time in timezones. We have to use moment-timezone extension for moment library which we already use.

The most tricky thing here is to validate somehow, that moment-timezone can understand our list of timezones https://github.com/appirio-tech/react-components/blob/feature/connectv2/constants/timezones.js. So we don't come up with the situation, when for some timezones in our list moment-timezone cannot properly calculate the local time.

[maxceem]

F2F for this issue is on http://www.topcoder.com/challenges/30111812

[maxceem]

It's done via F2F. Also, verified, that all timezones in our list are supported by the library we use to for calculating local time.

Also, now we can easily show timezone in the 3-letter format, as was initially shown in the designs:

Though, I propose to keep showing timezone as UTC offset, as I guess not all the people know all the 3-letter timezones while by UTC offset everyone can read the time difference:

• but on the other hand we can calculate the time difference from the actual shown local time, so let me know if you would like to show 3-letter codes instead of UTC offset.

cc @RishiRajSahu

[maxceem]

It's done in the branch https://github.com/appirio-tech/connect-app/tree/hotfix/local-timezone https://github.com/appirio-tech/connect-app/tree/fix-local-timezone-selection via PR #3473 #3479

[RishiRajSahu]

@maxceem @vikasrohit I think this could with our next release and we can merge this to dev branch for now, do you guys agree ?

[maxceem]

Yes, I think that should be fine as I guess not so many people have entered their working hours yet, so not many users would come across with this issue.

[mahestro]

Hi guys, sorry to interrupt the flow the discussion here with a somehwat related topic.

Is the sun/moon icon meant to represent the current natural light disposition? Meaning, if it's 8:32 am in the morning, should it display a sun icon? If that's so, I think we can take advantage of this Github issue to include that fix, check: https://take.ms/2GUdr

Maybe it's a duplicate issue and I didn't see it. I can create a new issue if necessary.

Let me know.

[RishiRajSahu]

@mahestro sun/moon icon are shown as per working hours of an individual.

[maxceem]

This is done and pushed to DEV branch now.

[maxceem]

QA guidelines:

• Set New York timezone on your computer
• Set some project member to use New York timezone
• Check that Connect shows correct local time for this user in the member list
• Now change time on your PC to any time between April and October (summer time)
• Check that Connect shows correct local time for this users again