[$200] Empty message breaks showing all the messages

[maxceem]

This error happened on PROD for the client project.

Create a post with the next body:

{
            "id": 111111,
            "date": "2020-12-08T21:58:35.334Z",
            "updatedDate": "2020-12-08T21:59:04.087Z",
            "userId": 111111,
            "read": false,
            "body": " ",
            "rawContent": " ",
            "attachments": [],
            "type": "post"
          }

Load the Messages page with such a message. You would see no message and error in the console:

For local testing you may add the next code inside the file https://github.com/appirio-tech/connect-app/blob/574231d25b0f9a66c9b7e4bc254dd97c23880da5/src%2Fapi%2Fmessages.js and hardcode it as a response for getTopics API method.

const rep = {
  "id": "8a237331-14a8-4561-943c-c7b4d7ef25f7",
  "version": "v5",
  "result": {
    "success": true,
    "status": 200,
    "content": [
      {
        "id": 1111111,
        "reference": "project",
        "referenceId": "25233",
        "tag": "PRIMARY",
        "date": "2020-10-27T12:18:51.950Z",
        "updatedDate": "2020-12-08T21:58:55.454Z",
        "lastActivityAt": "2020-12-08T21:58:55.447Z",
        "title": "test",
        "userId": 1111111,
        "totalPosts": 1,
        "retrievedPosts": 1,
        "postIds": [
          1111111
        ],
        "posts": [
          {
            "id": 1111111,
            "date": "2020-12-08T21:58:35.334Z",
            "updatedDate": "2020-12-08T21:59:04.087Z",
            "userId": 1111111,
            "read": false,
            "body": " ",
            "rawContent": " ",
            "attachments": [],
            "type": "post"
          }
        ],
        "read": false
      },
    ],
    "metadata": {
      "totalCount": 1
    }
  }
}

TODO:

1. This is not the first time when some particular message breaks the rendering of all messages. So we have to catch errors during rendering posts and don't let one bad message to break all the posts. When we fail to render one message, instead of the message we should show:
   • row code of the message, so users can still know what is inside
   • small error message, that we could not render the message properly, please contact Topcoder Support
2. Fix rendering method, so if we have an empty message (with spaces only) it doesn't get broken and just shows an empty message.
3. Don't allow posting empty messages (with space only).

[acshields]

@maxceem @RishiRajSahu - is this a fix we can get done before 1/15? Right now, I am tagging this to January, but depending on your response I may deprioritize.

[maxceem]

@acshields Yes, I would prefer to fix it as soon as possible to avoid breaking messages for customers.

[acshields]

I am good with that. Let's get this in motion ASAP. As a reminder, this will need to be done before or by 1/15 :)

[maxceem]

Contest https://www.topcoder.com/challenges/30161155 has been created for this ticket.

This is an automated message for maxceem via Topcoder X

[Gauravseta]

@maxceem please assign to me

[Gauravseta]

@bug-bash-helper please assign to me

[bug-bash-hunt-helper]

@Gauravseta 🛑 this issue is not included in the Bug Bash.

You may only pickup issues which are included in this Bug Bash and open for pick up.
Such issues have open status and have labels CF and Open for Pickup.

[maxceem]

Sorry @Gauravseta this issue is open only for a few members as a private task. It is not opened for the public this time.