Skip to content

Github issue#1218, Proper fix for hiding any project category #1219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vikasrohit merged 1 commit into from
Oct 3, 2017
Merged

Github issue#1218, Proper fix for hiding any project category #1219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/config/projectWizard/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ const products = {
info: 'Build a cognitive chat bot for your product',
question: 'What do you need to develop?',
id: 'chatbot',
hidden: true,
subtypes: {
'Watson Chatbot': {
brief: 'Watson Chatbot',
Expand Down Expand Up @@ -188,7 +189,7 @@ export function findProduct(product) {

export function findCategory(categoryId) {
for(const key in products) {
if (products[key].id === categoryId) {
if (products[key].id === categoryId && !products[key].disabled) {
return { ...products[key], name: key}
}
}
Expand Down
6 changes: 0 additions & 6 deletions src/projects/create/components/ProjectTypeCard.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,6 @@
-moz-transition: 300ms all ease;
-webkit-transition: 300ms all ease;

// Hide the chatbot card
// FIXME: Remove when chatbot should be enabled again
&:nth-child(3) {
display: none;
}

.sub-type-details {
padding: 0 20px;
font-size: 13px;
Expand Down
3 changes: 3 additions & 0 deletions src/projects/create/components/SelectProjectType.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ function SelectProjectType(props) {
const item = config[key]
const icon = <SVGIconImage filePath={item.icon} />
const products = findProductsOfCategory(item.id) || []
// don't render disabled items for selection
// don't render hidden items as well, hidden items can be reached via direct link though
if (item.disabled || item.hidden) continue
cards.push(
<ProjectTypeCard
icon={icon}
Expand Down