Skip to content

mobility testing added to the catalogue #1272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vikasrohit merged 2 commits into from
Oct 18, 2017
Merged

mobility testing added to the catalogue #1272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85f2c1b
Github issue#1198, Mobility Testing product on Connect
Oct 18, 2017
83e5611
Fixed lint errors
Oct 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions src/components/SelectDropdown/SelectDropdown.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,19 @@ class SelectDropdown extends Component {
}

componentWillMount() {
let selectedOption = _.find(this.props.options, (o) => o.value === this.props.value)
if (!selectedOption) {
selectedOption = this.props.options[0]
}
this.setState({
selectedOption: this.props.selectedOption || this.props.options[0]
}, function() {
this.props.setValue(this.state.selectedOption)
})
selectedOption
}/*, function() {
// FIXME intentionally commented because it was causing multiple renders when used in mobility testing template
// Need to further analyze
// It does not seem to add any value either in both of its usage (it is used in App Screens section
// for design projects and in mobility testing projects)
this.props.setValue(this.state.selectedOption.value)
}*/)
}

handleClick(option) {
Expand All @@ -25,7 +33,7 @@ class SelectDropdown extends Component {
this.props.onSelect(this.state.selectedOption)
}
})
this.props.setValue(option)
this.props.setValue(option.value)
}

render() {
Expand Down
Loading