Skip to content

Conversation

@vikasrohit
Copy link

fyi @vic-topcoder @dmessing

Vikas Agarwal added 3 commits November 6, 2017 16:09
…env web pack config for all feature branches instead of blocking them completely.
@vikasrohit
Copy link
Author

@gondzo I think you copiloted the stuff where we removed webpack-config from dependencies. Please let me know if the changes to config/constants/index.js makes sense to you.

@gondzo
Copy link
Collaborator

gondzo commented Nov 6, 2017

Yeah, it makes sense to use dev for all branches except master and qa which have different values. Good catch! @vikasrohit

@vikasrohit vikasrohit merged commit 1ed7554 into dev Nov 7, 2017
@vikasrohit
Copy link
Author

Thanks @gondzo

@vikasrohit vikasrohit deleted the feature/lost-ref-code-incomplete-project branch November 20, 2017 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants