Skip to content

Remove global notifications section if is 0 #1550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gondzo merged 1 commit into from
Dec 26, 2017
Merged

Remove global notifications section if is 0 #1550

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/routes/notifications/helpers/notifications.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,11 @@ const MILLISECONDS_IN_MINUTE = 60000
export const getNotificationsFilters = (sources) => {
const globalNotificationsQuantity = _.find(sources, { id: 'global' }).total
const filterSections = [
[{ title: 'All Notifications', value: '' }],
[{ title: 'Global', value: 'global', quantity: globalNotificationsQuantity }]
[{ title: 'All Notifications', value: '' }]
]
if (globalNotificationsQuantity > 0) {
filterSections.push([{ title: 'Global', value: 'global', quantity: globalNotificationsQuantity }])
}
const filtersBySource = []

sources.forEach(source => {
Expand Down