Skip to content

Fix text area auto-sizing #1576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vic-georgiev merged 3 commits into from
Jan 2, 2018
Merged

Fix text area auto-sizing #1576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ecc36a8
Fix text area auto-sizing
ThomasKranitsas Dec 29, 2017
64ce81b
Merge branch 'dev' of https://github.com/appirio-tech/connect-app int…
ThomasKranitsas Jan 1, 2018
0e97e28
Fix auto-resize issue in textbox
ThomasKranitsas Jan 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/projects/detail/components/EditProjectForm.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,15 +100,24 @@ class EditProjectForm extends Component {
window.addEventListener('beforeunload', this.onLeave)
}

autoResize() {
if (self.autoResizeSet === true) { return }
self.autoResizeSet = true
setTimeout(() => {
window.dispatchEvent(new Event('resize'))
}, 1000)
}

componentWillUnmount() {
this.props.fireProjectDirtyUndo()
window.removeEventListener('beforeunload', this.onLeave)
}

// Notify user if they navigate away while the form is modified.
onLeave(e = {}) {
this.autoResize()
if (this.isChanged()) {
// TODO: remove this block - it disables unsaved changes popup
// TODO: remove this block - it disables unsaved changes popup
// for app screens changes
if (this.refs.form){
const pristine = this.refs.form.getPristineValues()
Expand Down Expand Up @@ -237,7 +246,7 @@ class EditProjectForm extends Component {
value={ _.get(project, 'details.appDefinition.features', {})}
/>
</Formsy.Form>

</div>
)
}
Expand Down
2 changes: 1 addition & 1 deletion src/projects/detail/components/SpecQuestionList/SpecQuestionList.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
text-align: left;
text-indent: 0;
margin-bottom: 0;
line-height: 25px;
line-height: 24.5px;
}

.radio-group-input,
Expand Down
2 changes: 1 addition & 1 deletion src/projects/detail/components/SpecSection.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const SpecSection = props => {
!subSection.hideTitle &&
<div className="sub-title">
<h4 className="title">
{typeof subSection.title === 'function' ? subSection.title(project): subSection.title }
{typeof subSection.title === 'function' ? subSection.title(project): subSection.title }
<span>{((typeof subSection.required === 'function') ? subSection.required(project, subSections) : subSection.required) ? '*' : ''}</span>
</h4>
</div>
Expand Down