Skip to content

Conversation

@sachin-maheshwari
Copy link

No description provided.

Copy link
Contributor

@RishiRajSahu RishiRajSahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vikasrohit
Copy link

vikasrohit commented Apr 10, 2018

Can we create a another PR against dev for the same changes? And merge that in dev and verify that it works in dev env.

BTW, PR looks good to me.

@vikasrohit vikasrohit changed the title hotfix: v5 deployment - changes in tc-notifications endpoints. [Production Deployment] hotfix: v5 deployment - changes in tc-notifications endpoints. Apr 10, 2018
@vikasrohit
Copy link

I think we are okay @sachin-maheshwari. @RishiRajSahu reminded me that these changes are already in dev and seems to work fine.

Copy link

@vikasrohit vikasrohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sachin-maheshwari sachin-maheshwari merged commit 1fbd8d9 into master Apr 12, 2018
@vikasrohit vikasrohit deleted the hotfix/v5-notifications-endpoint-change branch August 21, 2018 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants