Fixed code to make maintenance and error pages visible #2005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is page MAINTENANCE_MODE should be set to true in src/config/constants.js near line 321
…xported instead of just routes, which is capturing any unmatched route and making any route below this unaccessible (e.g. /404 or /error). Also, comma after jsx comments is required because jsx is not contained inside any function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now maintenance page breaks for me due to missing react import in Maintenance.jsx and /error and /404 error pages are not visible due to screwed up routing in src/routing/settings page. My this pull request fixes both issues to make these pages working. Please give feedback.