fix freezing project dashboard page on mobile resolutions #2169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR
The fix is easy, clear and robust, safe for deploy.
Details
The issue was with the package react-text-truncate that we use to truncate too long project description on the dashboard with
read morelink.For mobile resolutions, the truncate maximum lines has been set to
Infinitywhich caused in some circumstances the infinite loop in the plugin, see https://github.com/ShinyChang/React-Text-Truncate/blob/master/src/TextTruncate.js#L133I put
1000as trancate maximum lines, feels like this is enogh for project descriptions to be shown fully without trancations.NOTE, that even big finite values like
1 000 000cause browser to freeze.