Skip to content

Hotfix/error in adding new phase to old v3 projects #2402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vikasrohit merged 6 commits into from
Aug 21, 2018
Merged

Hotfix/error in adding new phase to old v3 projects #2402

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2c99225
Merge pull request #2386 from appirio-tech/hotfix/maintenance_mode_ev…
Aug 16, 2018
1573206
Merge pull request #2388 from appirio-tech/dev
Aug 16, 2018
360e4a8
Merge pull request #2389 from appirio-tech/dev
Aug 16, 2018
9bda3a3
Merge pull request #2390 from appirio-tech/dev
Aug 16, 2018
1e55489
Merge pull request #2393 from appirio-tech/dev
Aug 17, 2018
bf57585
Github issue#2398, Impossible to add phases to older project
Aug 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/projects/actions/project.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,14 +280,18 @@ export function createProduct(project, productTemplate, phases, timelines) {
const lastMilestone = _.maxBy(timelineState.timeline.milestones, 'order')
// calculates the start date for the new phase by adding 1 day to the end date of the milestone
// we don't use end date field of milestone because it might not reflect the correct end date
startDate = moment(lastMilestone.startDate).hours(0).minutes(0).seconds(0)
.milliseconds(0).add(lastMilestone.duration - 1, 'days').add(1, 'days')
} else {
if (lastMilestone && lastMilestone.startDate) {
startDate = moment(lastMilestone.startDate).hours(0).minutes(0).seconds(0)
.milliseconds(0).add(lastMilestone.duration - 1, 'days').add(1, 'days')
}
} else if (phase.startDate) {
// if there is no timeline for the phase, calculates the next phase's start date by adding 1 day to the
// end date of last phase, we don't use end date field of milestone because it might not reflect the
// correct end date
startDate = moment(phase.startDate).hours(0).minutes(0).seconds(0)
.milliseconds(0).add(phase.duration - 1, 'days').add(1, 'days')
} else {
// do nothing, use today as start date
}
}
// assumes 10 days as default duration, ideally we could store it at template level
Expand Down